[Bug]: Theming issues due to theming apps not being uninstalled in a clean way

HannesJo0139 commented 1 year ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] Nextcloud Server is running on 64bit capable CPU, PHP and OS.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

I just switched to light theme and noticed that icons are barely visible now as you can see in the screenshot attached. Strange thing is on a test instance I am not able to reproduce the issue.

On main instance for some reason it sets [data-themes*=dark] and so icons for the dark theme are being loaded. The test instance sets [data-themes*=light] what seems to be correct. Any idea how to debug it?

Barely visible icons:

Icons being loaded via [data-themes*=dark]:

Correct icons on test instance, being loaded via [data-themes*=light]:

Steps to reproduce

Unable to reproduce myself..

Expected behavior

Having correct icons..

Installation method

None

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

[ ] Default user-backend (database)
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

No response

List of activated Apps

root@27d93249669e:/# occ app:list
Enabled:
  - activity: 2.17.0
  - admin_audit: 1.15.0
  - calendar: 4.2.4
  - checksum: 1.2.0
  - cloud_federation_api: 1.8.0
  - comments: 1.15.0
  - contacts: 5.1.0
  - contactsinteraction: 1.6.0
  - dav: 1.24.0
  - external: 5.0.2
  - extract: 1.3.5
  - federatedfilesharing: 1.15.0
  - federation: 1.15.0
  - files: 1.20.1
  - files_downloadactivity: 1.15.0
  - files_pdfviewer: 2.6.0
  - files_rightclick: 1.4.0
  - files_sharing: 1.17.0
  - files_trashbin: 1.15.0
  - files_versions: 1.18.0
  - firstrunwizard: 2.14.0
  - imageconverter: 1.3.4
  - impersonate: 1.11.0
  - logreader: 2.10.0
  - lookup_server_connector: 1.13.0
  - nextcloud_announcements: 1.14.0
  - notifications: 2.13.1
  - oauth2: 1.13.0
  - oidc_login: 2.4.1
  - onlyoffice: 7.6.8
  - password_policy: 1.15.0
  - previewgenerator: 5.2.1
  - privacy: 1.9.0
  - provisioning_api: 1.15.0
  - recommendations: 1.4.0
  - related_resources: 1.0.4
  - riotchat: 0.14.1
  - serverinfo: 1.15.0
  - settings: 1.7.0
  - sharebymail: 1.15.0
  - support: 1.8.0
  - survey_client: 1.13.0
  - systemtags: 1.15.0
  - text: 3.6.0
  - theming: 2.0.1
  - theming_customcss: 1.12.0
  - twofactor_backupcodes: 1.14.0
  - twofactor_nextcloud_notification: 3.6.0
  - twofactor_totp: 7.0.0
  - updatenotification: 1.15.0
  - user_status: 1.5.0
  - viewer: 1.9.0
  - workflowengine: 2.7.0
Disabled:
  - breezedark: 25.0.0
  - bruteforcesettings: 2.4.0
  - circles: 24.0.0
  - dashboard: 7.0.0
  - encryption
  - files_external: 1.10.0
  - photos: 2.0.1
  - suspicious_login
  - user_ldap
  - weather_status: 1.0.0

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

szaimen commented 1 year ago

Hi, which nc version?

HannesJo0139 commented 1 year ago

25.0.4

damu-u commented 1 year ago

icon

I have the same problem 25.0.4

HannesJo0139 commented 1 year ago

Tried to do some debugging today. All I can say is after setting up a brand new nc instance, everything is fine. As soon as I link it to the database of my main instance (mariadb, using a db backup of course), the issue occurs again.

HannesJo0139 commented 1 year ago

Had time for a few more tests today. Apparently, the problem is related to a deleted theming app (Breeze-Dark). I no longer use the app and have removed it completely from a user / admin perspective. Nevertheless, the body tag is

<body id="body-user" data-theme-breezedark data-theme-light data-themes=breezedark,light>

Editing the body tag so that the breezedark stuff is removed corrects the icon colors. Only the folder sizes are still invisible. So it seems to be an issue about how uninstalled apps are handled by nextcloud. Related to https://github.com/nextcloud/server/issues/5539

Would be glad if someone could tell how to get rid of the breeze-dark leftovers from my nc instance.

@damu-u Did you use breeze dark too?

https://github.com/mwalbeck/nextcloud-breeze-dark/issues/330

damu-u commented 1 year ago

@HannesJo0139 Yes, I installed the breeze dark theme and then deleted it.

HannesJo0139 commented 1 year ago

Quick and dirty workaround is to edit table _ocpreferences in the database by hand. Remove entries where _appid is theming and _configkey is enabled-themes. Amazing how Nextcloud clutters up its database.

szaimen commented 1 year ago

Duplicate of https://github.com/mwalbeck/nextcloud-breeze-dark/issues/330

HannesJo0139 commented 1 year ago

Duplicate of mwalbeck/nextcloud-breeze-dark#330

@szaimen I don't think closing as duplicate is appropriate. The issue is clearly not a breeze-dark issue but a nextcloud one. Nextcloud does not handle app uninstall properly. I opened that 2nd issue at breeze-dark package only so the dev becomes aware of an upstream problem.

szaimen commented 1 year ago

What you are looking for is a not yet implemented feature: https://github.com/nextcloud/server/issues/5539

HannesJo0139 commented 1 year ago

The feature is another topic. But a deactivated app must not affect my nc instance anymore. If it does, its a bug.

nextcloud / server