nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.36k stars 4.06k forks source link

Allow the user to use the system font for the GUI. #36867

Open RokeJulianLockhart opened 1 year ago

RokeJulianLockhart commented 1 year ago

How to use GitHub

Is your feature request related to a problem? Please describe. My friends who have dyslexia have expressed that they'd like to use the font that they use for the machines in the websites that they visit without braking them, although I must note that they don't particularly mind the one that Nextcloud currently provides. For me, this is problematic because I see no reason why Nextcloud should mandate its own font instead of the system/browser-provided one.

Describe the solution you'd like (Allow the user to) use the browser-provided typeface, ideally by default.

Describe alternatives you've considered Allow the user to choose the font from a combination box, of which 3 of the options are sans-serif, serif, and monospace, thereby allowing the user to use the browser-provided fonts for those standard aliases.

Additional context https://help.nextcloud.com/t/85305/2?u=rokejulianlockhart isn't correct, at least for http://wim.nl.tab.digital.

kesselb commented 1 year ago

this is problematic because I see no reason why Nextcloud should mandate its own font instead of the system/browser-provided one.

We don't ship a font for default theme

http://wim.nl.tab.digital/

The page is using the system font on my machine

dyslexia

When your friend select the dyslexia accessbility option the opendyslexic font is loaded. If your friend dislikes it I assume it should work to not enable the option and let the browser overwrite it.

RokeJulianLockhart commented 1 year ago

@kesselb, I'm quite confident that you're incorrect. Have you forgotten to alter firefox's font.name* keys (or your browser's alternative)? Some of them are available at

firefox about:preferences#general

To demonstrate:

browser-defined font

image

To set:

firefox about:config
browser.display.use_document_fonts 0

nextcloud-defined font

image

To set:

firefox about:config
browser.display.use_document_fonts [1]()

Yeah, I don't know why I didn't of your response to the dyslexia font problem. They might be using macOS or Windows, in which case I can sort of understand them not having changed the typeface of their system. They've definitely changed the browser font, though. I'll check with them. Thanks.

kesselb commented 1 year ago

We migrated to a native font stack a while ago: https://github.com/nextcloud/server/pull/16055

The css rules are here nowadays: https://github.com/nextcloud/server/blob/850d8ac1cd9e5b28e37668469237d8daa5c5d51d/apps/theming/css/default.css#L38

That means we provide a list of font's and the browser will pick which one to use.

I assume your request is about removing the --font-face definition. That's a question for @jancborchardt and @nimishavijay.

Screenshot from 2023-03-02 14-40-44

@jancborchardt @nimishavijay You may uncheck "Allow pages to choose their own fonts" to see how it looks on your system (browser.display.use_document_fonts = 0).

@rokejulianlockhart isn't browser.display.use_document_fonts = 0 the best approach for your friends with dyslexia? It will tell the browser to ignore any font definition and use the default in Firefox. The browser seems like the right place for this.