[Bug]: (strings) Non plain English, non translatable property name in queueUpdate() success message

silopolis commented 1 year ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] Nextcloud Server is running on 64bit capable CPU, PHP and OS.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

The queueUpdate() success message uses the share's raw property name, which is not that English users friendly and not translatable.

Plus, my shamy PHP non-skills make me believe that it doesn't return all properties when several properties are passed to queueUpdate().

https://github.com/nextcloud/server/blob/master/apps/files_sharing/src/mixins/SharesMixin.js#L280

Steps to reproduce

Update share properties and get a success message

Expected behavior

Have user messages in plain English and translatable, whether one or several properties are passed to queueUpdate().

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

[ ] Default user-backend (database)
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

No response

List of activated Apps

Files

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

szaimen commented 1 year ago

cc @Pytal

Pytal commented 1 year ago

This would need a mapping between the property name and readable string for all properties passed to queueUpdate() https://github.com/search?q=repo%3Anextcloud%2Fserver+queueUpdate&type=code

And yes since there may be multiple properties (introduced in https://github.com/nextcloud/server/pull/20938) we'd have to show each one

nextcloud / server