nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.77k stars 4k forks source link

[Bug]: Delete user - Wipe all devices - Disable user #38643

Open marinofaggiana opened 1 year ago

marinofaggiana commented 1 year ago

⚠️ This issue respects the following points: ⚠️

Bug description

According to client management the functions for deleting a user are not correctly handled.

-1- If you delete a user clients get a 401 http error (JSON internal error 997) we are then forced to block the flow, delete the password and immediately request new credentials, which would practically also mean deleting the internal files as server-side, otherwise one would not understand why deleting a user and leaving the data within the client would take up so much space on the phone.

So you don't understand the real difference between delete user and wipe all devices

-2- Disabling the user should be momentary, so that temporarily the client no longer has access to the server (although it can still consult the local data?). But on the client side there is no difference between Delete user and Disable user (error 401 JSON error 997) which would still mean having to request credentials with the login mask.

-3- For more than a few customers, it happens that the user on his phone inexplicably receives a 401 and is forced to log in, are we sure that on the server side nobody has disabled the user so this 401 was generated somewhere .

Steps to reproduce

  1. select a user
  2. choice an option for delete / wipe / disable

Expected behavior

-1- the duplicate of Delete user / Wipe all device should simply be "Delete user" I would like to remind you that at least under iOS, the data in the sandbox is and will remain unlawful, so even if you do not destroy the local data, it will remain unusable.

-2- use a different error between delete and disable.

-3- Deleting or disabling a user should generate an error that is not a 401 standad as it can happen in other contexts as well.

Installation method

None

Nextcloud Server version

26

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

Configuration report

No response

List of activated Apps

not required for this type of issue.

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

marinofaggiana commented 1 year ago

cc @tobiasKaminsky for Android cc @claucambra for Desktop

Screenshot 2023-06-05 alle 11 09 45