joshtrichards
commented
1 year ago It looks to me like countSeenUsers() is working as intended:
/**
* returns how many users have logged in once
*But there is a misnomer and it's in occ user:report. It reports active users which is just the result of countSeenUsers() (I'm assuming that's where you got the "active" terminology.)
I interpret "active users" as being recently active or, at the very list, not disabled. But that's not what occ user:report populates that field with. So I get where you're coming from. :-)
So that field should probably be re-labeled to match the function populating it: seen users or used accounts or something. And a new field added to the report that is called enabled users which is "total users minus disabled users".
So the following current behavior:
www-data@4fbd80fb2bc6:~/html$ ./occ user:list
- curluser: cURL
- disableduser: disableduser
- frank: frank
- ncadmin: ncadmin
- ncuser: ncuser
www-data@4fbd80fb2bc6:~/html$ ./occ user:report
+------------------+---+
| User Report | |
+------------------+---+
| Database | 5 |
| | |
| total users | 5 |
| | |
| user directories | 1 |
| active users | 4 |
| disabled users | 1 |
+------------------+---+becomes:
www-data@4fbd80fb2bc6:~/html$ ./occ user:report
+------------------+---+
| User Report | |
+------------------+---+
| Database | 5 |
| | |
| total users | 5 |
| | |
| user directories | 1 |
| seen users | 4 |
| enabled users | 4 |
| disabled users | 1 |
+------------------+---+I believe that occ user:list as currently implemented will always output the same number as total users since it doesn't appear to have any filters on it (i.e. it includes disabled users):
www-data@4fbd80fb2bc6:~/html$ ./occ user:list -i
- curluser:
- user_id: curluser
- display_name: cURL
- email:
- cloud_id: curluser@http://nc-test.local:3680
- enabled: true
- groups:
- 0: curl-only
- quota: none
- last_seen: 2023-05-23T11:34:11+00:00
- user_directory: /var/www/html/data/curluser
- backend: Database
- disableduser:
- user_id: disableduser
- display_name: disableduser
- email:
- cloud_id: disableduser@http://nc-test.local:3680
- enabled: false
- groups:
- quota: none
- last_seen: 2023-06-04T16:51:57+00:00
- user_directory: /var/www/html/data/disableduser
- backend: Database
- frank:
- user_id: frank
- display_name: frank
- email:
- cloud_id: frank@http://nc-test.local:3680
- enabled: true
- groups:
- 0: newgroup
- quota: none
- last_seen: 1970-01-01T00:00:00+00:00
- user_directory: /var/www/html/data/frank
- backend: Database
- ncadmin:
- user_id: ncadmin
- display_name: ncadmin
- email:
- cloud_id: ncadmin@http://nc-test.local:3680
- enabled: true
- groups:
- 0: admin
- quota: none
- last_seen: 2023-06-07T12:16:27+00:00
- user_directory: /var/www/html/data/ncadmin
- backend: Database
- ncuser:
- user_id: ncuser
- display_name: ncuser
- email:
- cloud_id: ncuser@http://nc-test.local:3680
- enabled: true
- groups:
- quota: 15.6 MB
- last_seen: 2023-05-29T17:13:33+00:00
- user_directory: /var/www/html/data/ncuser
- backend: DatabaseThere might also be room for some enhancement work to add an option to specify whether to include "all users (the default)" or "enabled users only". I suspect PRs are welcome. :-)
Anth0rx
solracsf
blizzz
nextcloud-command
MPStudyly
⚠️ This issue respects the following points: ⚠️
Bug description
The function
countSeenUsers()seems to return the amount of users that have ever been registered, not only those active and registered currently:The following SQL statement to the Nextcloud database replicates the return value of this function:
The following SQL statement also outputs the
displayNamealongside theuseridto better see which users are considered bycountSeenUsers():The output of the SQL statement above includes already deleted LDAP accounts. So maybe this is a problem with the LDAP implementation of Nextcloud. Deleted users should not appear in the database.
Steps to reproduce
countSeenUsers():php occ user:listExpected behavior
The expected behaviour would be that the function
countSeenUsers()returns the same amount of users as the OCC commandphp occ user:list. Deleted (LDAP) users should not appear in the database.Installation method
Official All-in-One appliance
Nextcloud Server version
25
Operating system
Other
PHP engine version
PHP 8.0
Web server
Apache (supported)
Database engine version
PostgreSQL
Is this bug present after an update or on a fresh install?
Fresh Nextcloud Server install
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
Configuration report
List of activated Apps
Nextcloud Signing status
No response
Nextcloud Logs
No response
Additional info
No response