nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.53k stars 4.08k forks source link

Upgrade Litmus to 0.15 #39627

Open provokateurin opened 1 year ago

provokateurin commented 1 year ago

How to use GitHub

Is your feature request related to a problem? Please describe.

Currently we only test against litmus 0.13 which is not the newest version. The latest version contains new checks that uncover some problems in the Nextcloud WebDAV implementation like https://github.com/nextcloud/server/issues/39625.

Describe the solution you'd like Litmus should be upgraded to 0.14 which is the latest version. The development has been happening at https://github.com/notroj/litmus for years and http://www.webdav.org/neon/litmus/ doesn't seem to get updated anymore (or they just forgot it).

provokateurin commented 1 year ago

The copy_shallow test doesn't pass on litmus 0.14, this might be a problem with our implementation (it is a new test).

susnux commented 1 year ago

This is a problem with Sabre\DAV. It implements MOVE and then handles COPY like MOVE but with keeping the origin. But for WebDAV MOVE may only have the Depth: infinity header set, but COPY may have any Depth and servers MUST implement infinity (which we have) and 0 which fails (see litmus 0.14).

susnux commented 1 year ago

This is an upstream issue, see my PR: https://github.com/sabre-io/dav/pull/1495

provokateurin commented 1 year ago

I don't remember where this was, but the tests only fail on one endpoint and not on the other. Like /remote.php/dav/files works and /remote.php/webdav doesn't (or might be the other way around).

joshtrichards commented 2 months ago

I don't remember where this was

Maybe this: https://github.com/nextcloud/server/issues/39625#issuecomment-1657259075

provokateurin commented 2 months ago

I'm not sure if those issues are connected, but it could be.