Global search beta follow up

[Fenn-CS]

Follow up issues from https://github.com/nextcloud/server/pull/40823

TODO

High priority:

• [x] Typing in the user search filter doesn't show all the users, it seems that it shows only the preloaded ones
• [x] When filtering the local view (e.g. users) it's impossible to reset the view. When reopening the search modal, it should be possible to reset the search.
• [x] Search result links that should be improved to be actual links for a11y reasons

Other:

• [x] Icon inversion which does not work well now since icons come in white or black instead of one consistent color. (Black icons turn white and white icons turn black, leading to to white on white background issues)
• [x] Use the new people filter (selector) that @marcoambrosini is working on (Current people filter not completed) - DONE, however, NcPopover which is used has issues with closing triggers.
• [x] Update back-end API (if ability not already present) to show "Search in App" dynamically.
• [x] Remove person filter
• [x] BUG: Clicking outside the search modal needs two clicks on the magnifier icon to get the modal back.
• [x] BUG: Some app icons are white on white.
• [x] BUG: Modified timestamp bubbles change size on hover, have no pointing cursor.
• [x] BUG: Generally no feedback for no results.
• [x] BUG: Search people has white text on white background.
• [x] BUG: Search people has a tiny user bubble, barely wider than the avatar.
• [x] BUG: Search people No result goes to the top, overlaps other input.
• [x] BUG: Search people has no effect at all. The search string doesn't contain a person identifier.
• [x] Avatars are square. I guess that's because all previews are square so this makes sense technically. For a user, this is inconsistent with avatars, though
• [x] When previews do not exist (endpoint returns 404) the browser renders a placeholder for the broken image
• [x] x on apps/person selection changes size on hover
• [x] No space for icons in modified (Fenn-CS : Best handled at component level, migrate to vue lib repo? "Do not reserve space for icon in NcActionButton if no icon is provided"???)
• [x] x on apps/person selection should have pointing cursor

• [ ] People are not sorted, at least not by name

• [ ] Accidentally clicked the magnifier on mobile and found out it's impossible to close the modal

Needs full page reload to get back to the content.

[ChristophWurst]

Noticed during testing today

• [ ] Avatars are square. I guess that's because all previews are square so this makes sense technically. For a user, this is inconsistent with avatars, though
• [ ] When previews do not exist (endpoint returns 404) the browser renders a placeholder for the broken image

[ChristophWurst]

• [x] x on apps/person selection changes size on hover
• [ ] x on apps/person selection should have pointing cursor

[ChristophWurst]

• [ ] People are not sorted, at least not by name

[ChristophWurst]

• [x] Search result have a href of #. Opening them in a new tab brings you to the same page you were when searching, not the search result. This is probably an a11y issue too.

[blizzz]

Should https://github.com/nextcloud/server/issues/41484 be linked here, too?

[Altahrim]

• [x] Impossible to select a date in the future
• [ ] Search providers for admins like users should probably be hidden for non admins
• [x] #41492

[blizzz]

* [ ]  Search providers for admins like `users` should probably be hidden for non admins

Then there is the case with group admins who would have access to a portion of users :smiley:

[ChristophWurst]

• [ ] Accidentally clicked the magnifier on mobile and found out it's impossible to close the modal

Needs full page reload to get back to the content.

[SystemKeeper]

• [x] When clicking on a search result (e.g. Talk or Files) you don't jump to that file/conversation anymore, instead:

[ChristophWurst]

When clicking on a search result

TypeError: t.openResult is not a function
    click SearchResult.vue:1
    VueJS 4
    onClick NcListItem.mjs:171
    click NcListItem.mjs:223
    VueJS 3

Same for results of Mail and other search providers

[ChristophWurst]

• [x] BUG modal can only be opened once, then it auto-closes

1) Click magnifier icon 2) Click outside the modal 3) Click magnifier icon again 4) Nothing happens 5) Click magnifier icon again 6) Modal opens, closes again 7) goto 3.

[Fenn-CS]

When clicking on a search result (e.g. Talk or Files) you don't jump to that file/conversation anymore, instead:

Resolved in : https://github.com/nextcloud/server/pull/41785

[ChristophWurst]

https://github.com/nextcloud/server/issues/41381#issuecomment-1813247040 still happens and it's quite frustrating to have to reload the page every time I mislick the notification icon.

[Altahrim]

• [ ] Person filter don't find all users. It seems to load an initial list and only filter this list.

[jancborchardt]

• [x] When using the "Filter current view" in account management, it is not possible to reset the search. E.g. on tech-preview, opening the modal back again makes it come up with an already cleared search input so it is not clearable. But the search term is still applied in the main content behind the modal, as well as for e.g. the Giphy provider inside the modal.

[jancborchardt]

• [x] "Start typing in search" → "Start typing to search"
• [x] When clearing the search term by marking the whole thing and deleting it all in one, the results stay below the emptycontent view:

[ChristophWurst]

Accidentally clicked the magnifier on mobile and found out it's impossible to close the modal

[Fenn-CS]

@ChristophWurst we have this already https://github.com/nextcloud/server/issues/41422

[ChristophWurst]

Thanks. It was not clear from this ticket.