nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.64k stars 3.99k forks source link

Value of Fediverse account field is not sanity checked #42621

Open nickvergessen opened 8 months ago

nickvergessen commented 8 months ago

How to use GitHub

A colleague on our instance has set the fediverse field to Firstname Lastname, yielding the following error when you visit their profile: Undefined array key 1 at …/lib/private/Profile/Actions/FediverseAction.php#81

The problem is that https://github.com/nextcloud/server/blob/aa5f037af71c915424c6dcfd5ad2dc82797dc0d6/lib/private/Profile/Actions/FediverseAction.php#L81 just assumes it is an "Email alike" value.

We should add some sanity check there and also when adding a value.

hanwick commented 5 months ago

Interested in tackling this issue.