nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.35k stars 4.06k forks source link

Consider clearing `app_install_overwrite` (or warning about it when detected) for major version upgrades #43026

Open joshtrichards opened 9 months ago

joshtrichards commented 9 months ago

How to use GitHub

Is your feature request related to a problem? Please describe.

Previously force enabled apps are tracked and kept as forced through major Nextcloud Server version upgrades, triggering mysterious post-upgrade problems. This results in Help Forum posts + invalid bug reports here.

Describe the solution you'd like

We clear the app_install_overwrite parameter before major Nextcloud Server upgrades (or) we warn heavily when that config directive is in-place.

Describe alternatives you've considered

Additional context

szaimen commented 9 months ago

Consider clearing app_install_overwrite

This is what AIO already does since quite a while: https://github.com/nextcloud/all-in-one/blob/b17561d41e575c7efd45fac1a6fb410be79bbe37/Containers/nextcloud/entrypoint.sh#L171-L173

joshtrichards commented 9 months ago

This is what AIO already does since quite a while

Nice. I hadn't realized that. So AIO gives us some real-world field experience with the proposed behavior change. Even better! :-)