search

nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.16k stars 4.03k forks source link

Adjust Settings->Help links to online manuals to use selected language instead of English #43146

Open thomas-mc-work opened 8 months ago

thomas-mc-work commented 8 months ago

Is your feature request related to a problem? Please describe.

When a user clicks in ‘Help’ under the Setting menu, he’s leaded to a page in English. No matter of what he's chosen before.

Describe the solution you'd like

The help link should respect the respective language of the current user.

Describe alternatives you've considered

If that's not possible, then the default language from the config.php should be taken.

joshtrichards commented 8 months ago

Are you referring to the contents of the page at /settings/help itself?

Because, if so, I'd say it's a bug. However, at least in v28.0.1, I see it in the language of my currently logged in user.

thomas-mc-work commented 8 months ago

Are you referring to the contents of the page at /settings/help itself?

Yes, exactly!

I forgot to mention that I'm on 27.1.5.

joshtrichards commented 8 months ago

In v27 we use embedded documentation rather than the online documentation and we load it immediately when clicking "Help" (defaulting to the User Manual but also offering links to the embedded Admin Manual in the left panel). I believe the inline docs only get distributed in English.

In v28 it's a little different because we created a dedicated Help page (which is fully translated) in #40784 then we provide links to the online documentation. We dropped the embedded docs being the default behavior.

And the online docs have the full language set. For the time being, at least in v28, it's now at least possible for the user to manually choose their preferred language (by clicking v: latest in the lower left it pops up a menu with languages available for the online manual). That wasn't possible before due to the limited embedded docs.

Now that #40784 is done, we could also adjust the link generation (either in server or in the documentation go.php) to push the user to the online documentation most appropriate for their active language.