nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.31k stars 4.06k forks source link

[RFC] Sharing status indicator #43443

Open skjnldsv opened 8 months ago

skjnldsv commented 8 months ago

Hi @nextcloud/designers, we've had a few changes on the sharing status indicator and I've seen various changes requests or small sentences here and there that lead me to ask what you have in mind really.

Gathering data

From https://github.com/nextcloud/server/issues/41620

Current Medium with avatars + icons Remove label for shares from others
Sharing current sharing medium Sharing plain

@jancborchardt said We discussed it with @nextcloud/designers and will go with the middle option as that is a good middle ground between the 2, and it takes into account Clémentine’s feedback from user testing.

From https://github.com/nextcloud/server/pull/41656

@marcoambrosini said For what is worth, I also think it's better to always show the shared label at all times. I think it's the 2nd most important thing after the file name. Let's figure out a better strategy to make things clear soon!

Other references:

Current implementation

If I share a file, even multiple times with different shares, we use the following logic (was like that in old times too)

Share type Icon
link or email 🔗
group or federated group 👩‍👧‍👦
circles
not shared ⁺🧑

Final request

As far as I understood and this is where I need confirmation from you :)

Owner Shared with Result
mine none image
mine link or email image
mine group or federated group image
mine user image
someone else none image
someone else link or mail image
(you get the point for the Shared with icons) any owner-avatar + matching type icon that will be primary

:warning: If we have multiple shares, we use the logic mentioned above: mail/link, then group/federated group, then circles and finally user

It seems to be what I understood, please confirm so I can fix the code made in a hurry for 28! :pray:

jancborchardt commented 8 months ago

@skjnldsv so the current state was the result of discussions of @karlitschek and me, this is why it is like it is. We specifically do not want to show more icons or labels since we had that in a beta of the current release and it looked way too cluttered. Everything was important, so nothing was. This is why it was fixed with https://github.com/nextcloud/server/pull/41656


As to your specific questions – the first 4 entries look good.

However the shares from someone else don’t look like you show, but rather like this, which is as expected and designed: image

The only strangeness being the design folder which is shared with both groups and accounts, so the icons of the folder and the share action don’t line up (should both be the "group" icon by the logic you describe, right?): image

skjnldsv commented 8 months ago

Alright, seems like I'm missing some internal discussion :thinking:

Your messages from https://github.com/nextcloud/server/issues/41620 seems to say you wanted to go for the middle solution? Which seems to show both avater and sharing icon? This is the entire reason of me creating this thread. According to Marco's comments, there was no time to fully implement it for 28

Shall I assume you changed your mind and are ok keeping the the last one ?

I just wanted to avoid missing some stuff that seemed spread over multiple comments that the design team wanted :pray:

jancborchardt commented 8 months ago

@skjnldsv right, so from the mockups from https://github.com/nextcloud/server/issues/41620 for both @karlitschek and me both the 2 options on the right would work.

The middle option was never implemented and rather converted into the left option which is too much.

But since we had feedback that the option with only icons can lead to misunderstanding, not finding the share option, and considering both @karlitschek and I would be good with the middle solution – let’s try that out at least as a prototype, and possibly for 29.

During development with full text everywhere Medium with avatars + icons Current (Remove label for shares from others)
Sharing current sharing medium Sharing plain
skjnldsv commented 7 months ago

Looking good! Let's try to test this with NC30 and see if it still works out :)