[Bug]: Regression on external files (SMB) if caseSensitive is false

danielnachtrub commented 7 months ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

If external files are mounted via SMB, one of the recent commits introduced a bug that files cannot be accessed and directories cannot be listed anymore.

The affected change is shown here: https://github.com/nextcloud/server/commit/a45e12abc8881b347475877cd07f8fe33bfe8c77#diff-65a0745a50632503b67e22fc4fe11789b6cbd41e3fedd475076fcee2144da0d5R686

Omitting this section returns expected functionality.

Steps to reproduce

Add external storage via SMB
Disable case sensitive
Try to access external storage

Expected behavior

Files and Directories should be listed

Installation method

Community Docker image

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

[ ] Default user-backend (database)
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

Censored3 commented 3 months ago

Don't know if any extra info is needed on this, but I encountered this issue and discovered during traces that the folder queried on the SMB server is actually 2x the subfolder specified in the config.

E.g., if I configure server 1.2.3.4, share MyShare$, subfolder: Projects/Subproject, I see queries happening for folder: "Projects\Subproject\Projects\Subproject"

joshtrichards commented 2 months ago

Without more details I can't say for certain, but this may have been addressed by #43349 (which was released in 28.0.3 a few weeks after your report).

nextcloud-command commented 1 week ago

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

nextcloud / server