nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.29k stars 3.96k forks source link

Filetype filters on top of the files list (doc, pdf, jpg, ...) #45437

Closed artonge closed 2 days ago

artonge commented 2 months ago

@nextcloud/designers for mockups

szaimen commented 2 months ago

Example from google drive: image

jospoortvliet commented 2 months ago

@marcoambrosini wanted, in general, to also look at the search bar, but this brings in a whole 'what to do with search' discussion. Best that design comes up with a complete concept.

artonge commented 2 months ago

@nextcloud/designers can we have some proper mockups for that?

marcoambrosini commented 1 month ago

Kickoff call outcome @AndyScherzinger @artonge @susnux @szaimen

Also cc @karlitschek and @jancborchardt

Current rough idea of the worst case scenario (Recommended files in root folder + rich workspaces enabled)

Image

Current rough idea of the best case scenario (subfolder with no rich workspaces)

Image

jancborchardt commented 1 month ago

@marcoambrosini seems good, some feedback:

Open question: do these filters only filter the current folder or are they recursive? E.g. when I filter for "documents" in a folder, do I see all documents in the whole folder tree or just the ones present in the current folder? From a UX perspective I think the former is the most beneficial, but it's much more difficult to achieve technically. It's also what our competitors do when using these filters. @susnux suggested that there could be a switch between current folder and all subfolder filtering.

I would first go with what is doable technically in a nice way, we can always improve on that. But no to a switch between modes here, that would needlessly complicate it.

susnux commented 1 month ago

susnux suggested that there could be a switch between current folder and all subfolder filtering.

I would first go with what is doable technically in a nice way, we can always improve on that. But no to a switch between modes here, that would needlessly complicate it.

To clarify for me it is about having two options:

  1. Filter the current folder (e.g. if there are a lot of file, I know the folder but I just want to filter)
  2. Search for something (e.g. search for a PDF somewhere in the file tree
susnux commented 1 month ago

Questions: What file type filters do we use? All types we found in the list? Or a generic list like

(this list would be easy to implement)

Or more like specific files? (PDF, JPG...)

What does "Modified" filter? "yesterday" "last week"?

People: Should this only filter the owner?

jancborchardt commented 1 month ago

@susnux for all of these, I would follow Google Drive’s lead since that’s the solution spearheading this. cc @marcoambrosini

susnux commented 1 month ago

I started implementing it, but have a question: The mock up is using a drop down, shall we use it or go with actions? Especially for user filtering a drop down would be a completely new component to allow two menu levels (1. user 2. "shared the file", "owned the file", etc)

With a drop down it looks like this:

Screencast_20240605_223801.webm

marcoambrosini commented 1 month ago
Screenshot 2024-06-06 at 10 56 40

Hi @susnux, I think we should go with actions like in the global search. The different look is because of the smaller border radii but I was thinking about the actions component.

susnux commented 1 month ago

@marcoambrosini with actions it could look like this:

https://github.com/nextcloud/server/assets/1855448/ad6d4116-c203-4a77-8e3c-3919939e13d4

jancborchardt commented 1 month ago

@susnux nice! Could "Clear filter" go to the bottom of the action menu so the entries don’t all jump one down?

susnux commented 1 month ago

Could "Clear filter" go to the bottom of the action menu

Sure but then you need to scroll fully down to clear, is that ok?

sorbaugh commented 3 weeks ago

The related PR: https://github.com/nextcloud/server/pull/45708