Closed marcoambrosini closed 2 days ago
Not sure if related but the + button for groups is misaligned
It looks like you didn't link the vue library master @come-nc
For testing master without linking we need: #46230
@susnux #46230 is for stable29
NcBreadcrumbs spacing between breadcrumbs and new button
Not sure if related but the breadcrumbs jump a tiny bit at page load
IMO the alignment is better while the file list is loading
var(--border-width-input, 2px)
that is used in NcSelect. This creates inconsistencyNcInputfield height is too big
@susnux @ShGKme @GVodyanov please update the checkboxes if you fix some of those things
Duplicate of:
https://github.com/nextcloud-libraries/nextcloud-upload/issues/1275
NcDateTimePicker height is too big
The picker needs a general design update for 30: https://github.com/nextcloud-libraries/nextcloud-vue/issues/5951
Main menu at the top right doesn't look very compact and there is too much space between the action icon and text
This is the compact styling of NcListItem
, best we can do here is removing 4px padding from the inner wrapper, allowing a total size of 38px (height) (34px content + 2*2px focus visible outline). (currently one item is 42px height)
Not sure if related but the breadcrumbs jump a tiny bit at page load
Still happening: when you click on All files there is a spinner at the top right and it makes the breadcrumbs jump down a few px
See the alignment of the nav toggle and the breadcrumbs. It's fine until the loading spinner shows.
susnux: Resolved with https://github.com/nextcloud/server/pull/47370
Also, that loading spinner makes the view toggle jump to the left, so it should be left of that toggle instead.
susnux: resolved: https://github.com/nextcloud/server/pull/47370
This shows in apps too, like Mail
@ChristophWurst
This shows in apps too, like Mail
I strongly recommend to use NcInputField
for this:
Yep, agree. But vanilla inputs should also have the correct style.
Closing, moved few remaining things in new issues
Great job everyone and especially @marcoambrosini for driving this. We came out with a really much more refined interface. :)
Vue library
Draft https://github.com/nextcloud-libraries/nextcloud-vue/pull/5746
Server
Dashboard
Updater & AIO
cc @jancborchardt @nimishavijay @susnux @ShGKme @skjnldsv