nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.62k stars 3.99k forks source link

NC30 UI refresh cleanup #46016

Closed marcoambrosini closed 2 days ago

marcoambrosini commented 2 months ago

Vue library

Draft https://github.com/nextcloud-libraries/nextcloud-vue/pull/5746

Server

Dashboard

Updater & AIO

cc @jancborchardt @nimishavijay @susnux @ShGKme @skjnldsv

come-nc commented 2 months ago

Copie d'écran_20240702_165458 Not sure if related but the + button for groups is misaligned

marcoambrosini commented 2 months ago

It looks like you didn't link the vue library master @come-nc

susnux commented 2 months ago

For testing master without linking we need: #46230

hamza221 commented 2 months ago

@susnux #46230 is for stable29

ChristophWurst commented 1 month ago

NcBreadcrumbs spacing between breadcrumbs and new button

Not sure if related but the breadcrumbs jump a tiny bit at page load

Bildschirmfoto vom 2024-07-16 13-28-01 Bildschirmfoto vom 2024-07-16 13-28-03

IMO the alignment is better while the file list is loading

ChristophWurst commented 1 month ago

https://github.com/nextcloud/server/blob/87dc0614d703536843b878808a2721899df798b4/core/css/inputs.scss#L246

ChristophWurst commented 1 month ago

NcInputfield height is too big

Same as https://github.com/nextcloud/server/issues/46851?

ChristophWurst commented 1 month ago

image

marcoambrosini commented 1 month ago

@susnux @ShGKme @GVodyanov please update the checkboxes if you fix some of those things

susnux commented 1 month ago

https://github.com/nextcloud/server/issues/46460

skjnldsv commented 1 month ago

image

ChristophWurst commented 1 month ago

Bildschirmfoto vom 2024-08-05 09-52-16

ChristophWurst commented 1 month ago

image


Duplicate of:

https://github.com/nextcloud-libraries/nextcloud-upload/issues/1275

ChristophWurst commented 1 month ago

Bildschirmaufzeichnung vom 2024-08-06 07-44-57.webm

ChristophWurst commented 4 weeks ago

image

ChristophWurst commented 3 weeks ago

NcDateTimePicker height is too big

The picker needs a general design update for 30: https://github.com/nextcloud-libraries/nextcloud-vue/issues/5951

ChristophWurst commented 3 weeks ago

image image

ChristophWurst commented 2 weeks ago

image

susnux commented 2 weeks ago

Main menu at the top right doesn't look very compact and there is too much space between the action icon and text

This is the compact styling of NcListItem, best we can do here is removing 4px padding from the inner wrapper, allowing a total size of 38px (height) (34px content + 2*2px focus visible outline). (currently one item is 42px height)

ChristophWurst commented 2 weeks ago

Not sure if related but the breadcrumbs jump a tiny bit at page load

Still happening: when you click on All files there is a spinner at the top right and it makes the breadcrumbs jump down a few px

Bildschirmfoto vom 2024-08-20 13-31-41 Bildschirmfoto vom 2024-08-20 13-31-39

See the alignment of the nav toggle and the breadcrumbs. It's fine until the loading spinner shows.


susnux: Resolved with https://github.com/nextcloud/server/pull/47370

jancborchardt commented 2 weeks ago

Also, that loading spinner makes the view toggle jump to the left, so it should be left of that toggle instead.


susnux: resolved: https://github.com/nextcloud/server/pull/47370

ChristophWurst commented 1 week ago

https://github.com/nextcloud/server/blob/6d04ad829b2814090301b0101dc10fa0617dd783/core/css/inputs.scss#L256

This shows in apps too, like Mail

image

susnux commented 1 week ago

@ChristophWurst

This shows in apps too, like Mail

I strongly recommend to use NcInputField for this:

https://github.com/nextcloud/mail/blob/62f1cec233ab92a311bcb0f70967d49f64bd1d8d/src/components/SearchMessages.vue#L8-L13

ChristophWurst commented 1 week ago

Yep, agree. But vanilla inputs should also have the correct style.

marcoambrosini commented 2 days ago

Closing, moved few remaining things in new issues

jancborchardt commented 2 days ago

Great job everyone and especially @marcoambrosini for driving this. We came out with a really much more refined interface. :)