nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.34k stars 3.97k forks source link

[Bug]: Plain background broken on master/30 #46277

Closed AndyScherzinger closed 2 weeks ago

AndyScherzinger commented 1 month ago

⚠️ This issue respects the following points: ⚠️

Bug description

background-color

Steps to reproduce

  1. go to settings and choose any plain background color

Expected behavior

plain background color being used

Installation method

None

Nextcloud Server version

master

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

AndyScherzinger commented 3 weeks ago

cc @sorbaugh

susnux commented 3 weeks ago

@AndyScherzinger I tried to reproduce this issue but for me it works as expected I can not see the white background issue like in your screen cast. Could you have a look at the browser console for any errors?

We also have Cypress tests for this and they also succeed :thinking:

AndyScherzinger commented 3 weeks ago

Nothing on the console, FF latest

susnux commented 3 weeks ago

But from the color picker in your screen recording I can tell that this is not current master. Does it work now or still the same issue? As I can not reproduce this issue locally.

From the recording it seems like the value is correctly set but then either a background image or something else overwrites it...

AndyScherzinger commented 3 weeks ago
2024-07-10 21_56_47-Appearance and accessibility - Nextcloud Daily – Mozilla Firefox

Just tested again on daily. Issue still present for me

susnux commented 3 weeks ago

Caused by the text app which is always loading this styles: https://github.com/nextcloud/text/blob/837ca322c032da66220a81cae95125bce5dbd6a7/src/views/DirectEditing.vue#L128

cc @juliushaertl

juliushaertl commented 2 weeks ago

Fixed, thanks to @susnux in https://github.com/nextcloud/text/pull/6026