[Bug]: App permission for groups - broken group list

intervisionlord commented 4 months ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

Unable to select group wich can use application

Steps to reproduce

Go to app wich supports group permissions
Set "limit to groups"
Click on selector
No groups suggested
Start to fill this field
Relevant group appears
Select it
Selector does not filled by this group

Expected behavior

Correct suggestions in selector Correct adding to selector

Installation method

Community Manual installation with Archive

Nextcloud Server version

29

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 28.0.1 to 28.0.2)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

[X] Default user-backend (database)
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

joshtrichards commented 4 months ago

Reproduced. Thanks for reporting.

Visually it then breaks that setting for other apps one clicks through.

On the other hand, it seems to actually set the parameter (after reloading the page).

intervisionlord commented 4 months ago

Reproduced. Thanks for reporting.

Visually it then breaks that setting for other apps one clicks through.

On the other hand, it seems to actually set the parameter (after reloading the page).

Yes, technicaly the functionality works, this bug affects only appearence (visual part) (sry for my english)

yannicklescure commented 2 months ago

@joshtrichards Is someone already working on fixing that bug ? Otherwise, I'd like to try working on it.

joshtrichards commented 2 months ago

@yannicklescure No one is currently. I was just sitting down to bring together a couple interrelated matters:

this Issue (#46634)
39322
20685

I suspect these can all be solved at at once.

Code is here:

https://github.com/nextcloud/server/blob/063d4df47899dc626e025ec1760bccf356f16d9d/apps/settings/src/components/AppStoreSidebar/AppDetailsTab.vue#L22

Potentially of note is a similar use case which seems to work reasonably well so it might serve as a useful model:

https://github.com/nextcloud/server/blob/063d4df47899dc626e025ec1760bccf356f16d9d/apps/settings/src/components/AdminTwoFactor.vue#L20

It can be found under Admin->Security in the UI..

yannicklescure commented 2 months ago

@joshtrichards Thank you. I setup a dev environnement and I'll try to give it a shot this week. :)

yannicklescure commented 2 months ago

@joshtrichards Here's the fix https://github.com/nextcloud/server/pull/48504 :)

nextcloud / server