nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.39k stars 4.07k forks source link

[Bug]: App permission for groups - broken group list #46634

Open intervisionlord opened 3 months ago

intervisionlord commented 3 months ago

⚠️ This issue respects the following points: ⚠️

Bug description

Unable to select group wich can use application image

Steps to reproduce

  1. Go to app wich supports group permissions
  2. Set "limit to groups"
  3. Click on selector
  4. No groups suggested
  5. Start to fill this field
  6. Relevant group appears
  7. Select it
  8. Selector does not filled by this group image image

Expected behavior

Correct suggestions in selector Correct adding to selector

Installation method

Community Manual installation with Archive

Nextcloud Server version

29

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 28.0.1 to 28.0.2)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

joshtrichards commented 3 months ago

Reproduced. Thanks for reporting.

Visually it then breaks that setting for other apps one clicks through.

On the other hand, it seems to actually set the parameter (after reloading the page).

intervisionlord commented 3 months ago

Reproduced. Thanks for reporting.

Visually it then breaks that setting for other apps one clicks through.

On the other hand, it seems to actually set the parameter (after reloading the page).

Yes, technicaly the functionality works, this bug affects only appearence (visual part) (sry for my english)

yannicklescure commented 1 month ago

@joshtrichards Is someone already working on fixing that bug ? Otherwise, I'd like to try working on it.

joshtrichards commented 1 month ago

@yannicklescure No one is currently. I was just sitting down to bring together a couple interrelated matters:

I suspect these can all be solved at at once.

Code is here:

https://github.com/nextcloud/server/blob/063d4df47899dc626e025ec1760bccf356f16d9d/apps/settings/src/components/AppStoreSidebar/AppDetailsTab.vue#L22

Potentially of note is a similar use case which seems to work reasonably well so it might serve as a useful model:

https://github.com/nextcloud/server/blob/063d4df47899dc626e025ec1760bccf356f16d9d/apps/settings/src/components/AdminTwoFactor.vue#L20

It can be found under Admin->Security in the UI..

yannicklescure commented 1 month ago

@joshtrichards Thank you. I setup a dev environnement and I'll try to give it a shot this week. :)

yannicklescure commented 1 month ago

@joshtrichards Here's the fix https://github.com/nextcloud/server/pull/48504 :)