Weird URL for accounts -> recently active

kesselb commented 2 months ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

The URL for the "Recently active" list in the accounts manager is /settings/users/__nc_internal_recent.

It works and it's no problem form a technical point.

Only a bit weird, given that we use cleaner urls for admins and disabled accounts.

Admins: /settings/users/admin Disabled accounts: /settings/users/disabled

Steps to reproduce

Login as admin
Go to accounts management
Click "Recently active"
Notice url

Expected behavior

A clean url ;)

cc @sorbaugh @Pytal

Pytal commented 2 months ago

Yes this is intentional, initial idea was to use recent but since this would be breaking went with this id suggested by @susnux

kesselb commented 1 month ago

I see, to avoid conflicts with existing groups.

The id for the disabled accounts section should be changed.

If you add a group and call it "disabled", the section but also the group disappears :see_no_evil:

Screencast from 2024-07-28 19-57-12.webm

I'm reopening the issue for now, please let me know if you want me to log a fresh issue.

susnux commented 1 month ago

I think this can be solved by do not use fake groups but provide the groups as special lists. And the URLs could also just be adjusted to look nice by changing them to e.g. /settings/users/recent -> recent or disabled etc /settings/users/group/realGroupId -> for real groups

(or similar)

nextcloud / server