nextcloud / server

ā˜ļø Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.68k stars 4k forks source link

Password protected public link shares : time to improve password protection UI to avoid a trap that many users fall into #46988

Open Jerome-Herbinet opened 1 month ago

Jerome-Herbinet commented 1 month ago

For a long time now, the password protection UI has been the cause of failure for many users, whether "gifted" or not. Whether the password is optional (activated manually by clicking on the checkbox), proposed by default or even imposed, one step is often overlooked: recovering the password before it is hashed and irrecoverable. I see two improvements:

But this isn't perfect, because in the case of a password-protected public link offered by default or forced, there are 2 pieces of information to copy and paste (in one or even two separate e-mails, for example): the URL and the password. So perhaps, when the password is proposed by default or forced, you shouldn't put a copy button as I've just suggested, but copy automatically to the clipboard after creating the share. Example: "Share URL: {share url} - Share password: {share password}". In the case of shares where the password is completely optional (not proposed by default, and certainly not imposed), we would still have the copy button in the field, after manual activation of password protection.

2024-08-02_15-44 2024-08-02_15-37

How to use GitHub

Jerome-Herbinet commented 1 month ago

@nextcloud/designers you may hate me, but I love you šŸ˜‡

Mika-6-9 commented 1 month ago

Hi. For me, if there were to be changes in the code, it would be better to use the current share link copy button (see below) and transform it so that when you click on it, you copy something like: "The share link is: https://xxxxxxx and the password to access the link is: xxxxx" We would just have to copy this into an email. This would avoid a copy/paste (one for the link and one for the password). Another option: clicking on this link opens a "mailto" that puts this text in the body of the email.

image

jancborchardt commented 2 weeks ago

Yeah, I think both the suggestions by @Jerome-Herbinet and @Mika-6-9 make sense. The copy icon in the password field for when you are in the flow, or decide to password-protect an existing share, and the inclusion in the copied text to make it easier for quickly copying everything.

@Jerome-Herbinet @Mika-6-9 or anyone else in here, would you like to contribute this or parts of it as a pull request?

Jerome-Herbinet commented 2 weeks ago

Yeah, I think both the suggestions by @Jerome-Herbinet and @Mika-6-9 make sense. The copy icon in the password field for when you are in the flow, or decide to password-protect an existing share, and the inclusion in the copied text to make it easier for quickly copying everything.

@Jerome-Herbinet @Mika-6-9 or anyone else in here, would you like to contribute this or parts of it as a pull request?

I'm afraid I'm running out of skills in this context.

Mika-6-9 commented 2 weeks ago

I can test things, but I'm not a programmer Sorry

joshtrichards commented 5 days ago

Related: #46914