[Bug]: nextcloud 30 RC1 - Filter does not survive the change to a subdirectory

devnull4242 commented 1 month ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

I set the filter e.g. to "folder" and "PDFs" and hope that i can navigate to subfolders to find only PDFs.

Steps to reproduce

Nextcloud 30 RC 1
set filter to e.g. "folder" and "PDFs"
filter is set
change to subfolder
filter is unset

Expected behavior

After change to subfolder the filter is not unset but set to e.g. "folder" and "PDFs".

2024-08-15 07_34_59-Window

Installation method

Community Manual installation with Archive

Nextcloud Server version

master

Operating system

Other

PHP engine version

None

Web server

Other

Database engine version

Other

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 28 to 29)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

[X] Default user-backend (database)
[ ] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

susnux commented 3 weeks ago

This is done by design.

CC @sorbaugh @jancborchardt should we maybe only reset when changing the view?

sorbaugh commented 3 weeks ago

Resetting filters only when changing the view sounds good to me. @susnux would there be any potential pitfalls? But yeah, waiting also for @jancborchardt 's input.

susnux commented 3 weeks ago

would there be any potential pitfalls?

We had bug reports in the past that wanted to reset the search on navigation. Thats why we reset the filters when changing the directory. But now with the filters it might make sense to keep it active e.g. if you want to check also sub-directories for your search.

jancborchardt commented 3 weeks ago

Yes, agree with the bug report and to keep the filter active when doing simple folder navigation.

nextcloud / server