[Bug]: Favorites not working (WEB) on v29.0.5

teach404 commented 3 weeks ago

⚠️ This issue respects the following points: ⚠️

[X] This is a bug, not a question or a configuration/webserver/proxy issue.
[X] This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
[X] Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
[X] I agree to follow Nextcloud's Code of Conduct.

Bug description

The favorite folders are listed but when i click on one via the favorite menue the folder contains nothing even something is in there.

The favorite funktion on the ios app is working but not on the web (browser tested with chrome and firefox) and it worked in version 28 but after we upgraded to 29.0.5 we discovered the bug.

Steps to reproduce

click files
open favorite folder
nothing displayed (even message showed -> folder is empty)

Expected behavior

the content inside the folder is shown

Installation method

Community Manual installation with Archive

Nextcloud Server version

29

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Nginx

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 28 to 29)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

[ ] Default user-backend (database)
[X] LDAP/ Active Directory
[ ] SSO - SAML
[ ] Other

Configuration report

No response

List of activated Apps

{
    "system": {
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***"
        ],
        "log_type": "file",
        "loglevel": 2,
        "maintenance_window_start": "1",
        "forwarded_for_headers": [
            "HTTP_X_FORWARDED_FOR",
            "HTTP_X_FORWARDED"
        ],
        "logfile": "\/var\/log\/nextcloud\/nextcloud.log",
        "logdateformat": "F d, Y H:i:s",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "lost_password_link": "disabled",
        "version": "29.0.5.1",
        "overwrite.cli.url": "https:\/\/nextcloud.hebk.de\/",
        "htaccess.RewriteBase": "\/",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "default_phone_region": "DE",
        "updatechecker": true,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "overwriteprotocol": "https",
        "ldapIgnoreNamingRules": false,
        "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory",
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "theme": "",
        "share_folder": "\/Mit mir geteilt",
        "maintenance": false,
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "sendmail",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "26",
        "allow_local_remote_servers": true,
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0,
            "dbindex": 0,
            "password": "***REMOVED SENSITIVE VALUE***",
            "timeout": 0.5
        },
        "app_install_overwrite": [
            "rocketchat_nextcloud"
        ],
        "enable_previews": true,
        "enabledPreviewProviders": [
            "OC\\Preview\\PNG",
            "OC\\Preview\\JPEG",
            "OC\\Preview\\GIF",
            "OC\\Preview\\BMP",
            "OC\\Preview\\XBitmap",
            "OC\\Preview\\Movie",
            "OC\\Preview\\PDF",
            "OC\\Preview\\MP3",
            "OC\\Preview\\TXT",
            "OC\\Preview\\MarkDown",
            "OC\\Preview\\HEIC"
        ]
    }
}

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

zapato commented 3 weeks ago

I have the same problem after upgrading from version 29.0.4 to 29.0.5.

Seems the favorites use the url "index.php/apps/files/favorites/133?dir=/Bilder" which shows the "no favorites" message whereas "index.php/apps/files/files/133?dir=/Bilder" directly from files shows the correct folder.

The Problem only appears when using the web browser. Clicking favorite links in the iPhone app works without problems.

kamilkobak commented 3 weeks ago

I have the same problem after upgrading from version 29.0.4 to 29.0.5.

thomasgg23 commented 3 weeks ago

Same in our installations working fine with 29.0.4 and showing the "no favorites" message after updating to 29.0.5

flatterrich commented 3 weeks ago

The same applies to my installation, which worked perfectly with 29.0.4 and after the update to 29.0.5 shows the message "no favorites", but the files still have the favorite marking.

ImZorex commented 3 weeks ago

Few days ago updated to 29.0.5 from 29.0.4 as well and experiencing the same issue. Besides favrourite not showing, we also facing issue with Notes throwing "editing session expired" error.

Operating system Ubuntu 22.04.4 LTS

PHP engine version PHP 8.1.2

Web server Apache/2.4.52

Database engine version MySQL 8.0.39

pjft commented 3 weeks ago

Same. Removing and Re-adding Favorites doesn't change anything.

whisperdancer commented 3 weeks ago

I can confirm same for me. After update from 29.0.4 to 29.0.5, no favorites. IOS app favorites works. This issue appears to be with the web browser only. When updating, I noticed the files app was also updated, Updated to 2.1.1. I surmise the bug is with the files app update.

whisperdancer commented 3 weeks ago

While fixing this bug I kindly ask you to please consider fixing this older bug also. It appears related:

Files Web App not displaying folder description after NC 28 when navigating from Favorites https://github.com/nextcloud/server/issues/43402

Thank you!

sorbaugh commented 2 weeks ago

cc @susnux @skjnldsv seems to work on 30. Reproducible only on 29.0.5 (29.0.4 also used to work).

susnux commented 2 weeks ago

Fixed with https://github.com/nextcloud/server/pull/47501

nextcloud / server