nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.69k stars 4k forks source link

[Bug]: Files deleted in group folders are deleted by “unknown” #47570

Closed Jerome-Herbinet closed 5 days ago

Jerome-Herbinet commented 2 weeks ago

⚠️ This issue respects the following points: ⚠️

Bug description

I jumped for joy when I saw this new information in Nextcloud 30 and thought it was very useful in the context of group folders to know if deleted (voluntarily or not) items accessible to several people.

Except that it doesn't work and it marks “unknown” instead, which renders the feature useless.

On the other hand, when I delete an item that belonged to me (outside group folders), it does mark that it's me, but that's useless compared to the first scenario described.

2024-08-28_15-15

Steps to reproduce

  1. Create a group folder with files in it
  2. From a user other than yourself, who also has access to the group folder, delete one or more files and/or folders.
  3. From this second user, as from your user, you will notice that the user who initiated the deletion is marked as “unknown”.

Expected behavior

The user responsible for the deletion must be indicated. The only real use for this new feature is in the context of group folders (mostly in the workplace), so this needs to be corrected.

Installation method

Community Manual installation with Archive

Nextcloud Server version

master

Operating system

RHEL/CentOS

PHP engine version

PHP 8.2

Web server

Nginx

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 28.0.1 to 28.0.2)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

Configuration report

{
    "passwordsalt": "***REMOVED SENSITIVE VALUE***",
    "secret": "***REMOVED SENSITIVE VALUE***",
    "trusted_domains": [
        "nc30.test.mydomain.fr"
    ],
    "datadirectory": "***REMOVED SENSITIVE VALUE***",
    "dbtype": "mysql",
    "version": "30.0.0.10",
    "overwrite.cli.url": "https:\/\/nc30.test.mydomain.fr",
    "dbname": "***REMOVED SENSITIVE VALUE***",
    "dbhost": "***REMOVED SENSITIVE VALUE***",
    "dbport": "",
    "dbtableprefix": "oc_",
    "mysql.utf8mb4": true,
    "dbuser": "***REMOVED SENSITIVE VALUE***",
    "dbpassword": "***REMOVED SENSITIVE VALUE***",
    "updater.release.channel": "stable",
    "installed": true,
    "instanceid": "***REMOVED SENSITIVE VALUE***",
    "log_type": "file",
    "logfile": "\/var\/log\/nextcloud\/nc30.test.mydomain.fr\/nextcloud.log",
    "redis": {
        "host": "***REMOVED SENSITIVE VALUE***",
        "password": "***REMOVED SENSITIVE VALUE***",
        "port": 6379,
        "dbindex": 3,
        "timeout": 0
    },
    "skeletondirectory": "",
    "logtimezone": "Europe\/Paris",
    "mail_smtpmode": "smtp",
    "mail_smtpsecure": "ssl",
    "mail_from_address": "***REMOVED SENSITIVE VALUE***",
    "mail_domain": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
    "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
    "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpauthtype": "PLAIN",
    "default_language": "fr",
    "default_phone_region": "FR",
    "defaultapp": "dashboard,files,photos,activity",
    "trashbin_retention_obligation": "20,40",
    "versions_retention_obligation": "auto,40",
    "appstoreurl": "https:\/\/apps.nextcloud.com\/api\/v1",
    "check_for_working_wellknown_setup": false,
    "quota_include_external_storage": false,
    "cron_log": true,
    "has_internet_connection": true,
    "updatechecker": true,
    "appstoreenabled": true,
    "filelocking.enabled": true,
    "session_keepalive": true,
    "knowledgebaseenabled": true,
    "allow_user_to_change_display_name": true,
    "enable_previews": true,
    "enable_avatars": true,
    "auth.bruteforce.protection.enabled": true,
    "loglevel": 1,
    "log_rotate_size": 104857600,
    "mail_smtpauth": 1,
    "mail_smtpport": 465,
    "session_lifetime": 86400,
    "remember_login_cookie_lifetime": 1296000,
    "preview_max_filesize_image": 50,
    "activity_expire_days": 120,
    "maintenance_window_start": 1,
    "memcache.local": "\\OC\\Memcache\\APCu",
    "memcache.locking": "\\OC\\Memcache\\Redis",
    "memcache.distributed": "\\OC\\Memcache\\Redis",
    "app_install_overwrite": [
        "admin_audit",
        "user_ldap",
        "richdocuments",
        "onlyoffice",
        "workspace",
        "groupfolders",
        "deck"
    ],
    "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory",
    "maintenance": false
}

List of activated Apps

Enabled:
 - activity: 3.0.0
 - admin_audit: 1.20.0
 - approve_links: 1.0.2
 - assistant: 2.0.3
 - bruteforcesettings: 3.0.0
 - circles: 30.0.0-dev
 - cloud_federation_api: 1.13.0
 - collectives: 2.14.2
 - comments: 1.20.1
 - contactsinteraction: 1.11.0
 - context_chat: 3.0.2
 - dashboard: 7.10.0
 - dav: 1.31.1
 - deck: 1.13.1
 - federatedfilesharing: 1.20.0
 - federation: 1.20.0
 - files: 2.2.0
 - files_confidential: 3.0.3
 - files_downloadlimit: 3.0.0
 - files_pdfviewer: 3.0.0
 - files_reminders: 1.3.0
 - files_retention: 1.19.0
 - files_sharing: 1.22.0
 - files_trashbin: 1.20.1
 - files_versions: 1.23.0
 - firstrunwizard: 3.0.0
 - groupfolders: 18.0.0
 - guests: 4.0.0
 - impersonate: 1.17.0
 - integration_deepl: 1.2.0
 - integration_giphy: 1.0.11
 - integration_openai: 3.0.1
 - integration_replicate: 3.0.0
 - intros: 1.0.1
 - logreader: 3.0.0
 - lookup_server_connector: 1.18.0
 - mail: 3.7.7
 - nextcloud_announcements: 2.0.0
 - notes: 4.10.1
 - notifications: 3.0.0
 - oauth2: 1.18.0
 - onlyoffice: 9.3.0
 - password_policy: 2.0.0
 - photos: 3.0.2
 - privacy: 2.0.0
 - provisioning_api: 1.20.0
 - recommendations: 3.0.0
 - related_resources: 1.5.0
 - richdocuments: 8.4.5
 - serverinfo: 2.0.0
 - settings: 1.13.0
 - sharebymail: 1.20.0
 - sharereview: 1.1.0
 - support: 2.0.0
 - systemtags: 1.20.0
 - tables: 0.7.5
 - tasks: 0.16.1
 - text: 4.1.0
 - text2image_stablediffusion: 1.1.0
 - theming: 2.5.0
 - twofactor_backupcodes: 1.19.0
 - twofactor_nextcloud_notification: 4.0.0
 - updatenotification: 1.20.0
 - user_ldap: 1.21.0
 - user_status: 1.10.0
 - viewer: 3.0.0
 - weather_status: 1.10.0
 - workflowengine: 2.12.0
 - workspace: 4.0.0-dev3
Disabled:
 - encryption
 - files_external
 - survey_client: 2.0.0
 - suspicious_login
 - twofactor_totp
 - webhook_listeners

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

Can be provided if necessary

Additional info

No response

sorbaugh commented 2 weeks ago

@Pytal could you take a look? 🙏

sorbaugh commented 2 weeks ago

@come-nc maybe something that's missing here? https://github.com/nextcloud/groupfolders/pull/2951

See comment: https://github.com/nextcloud/documentation/pull/11757