search

nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.55k stars 4.08k forks source link

`user_saml` app disabled on upgrade process (27 > 28) caused all users Favorites to be deleted #47602

Open solracsf opened 3 months ago

solracsf commented 3 months ago

Steps to reproduce

  1. Upgrade to a major version (27 > 28) from the CLI
  2. App is disabled as "not compatible" (but it is) by the upgrade script, and re-enabled after also by the script
  3. In the meanwhile, all users Favorites (at least) where lost because deleted by the Cleanup step.

See also https://github.com/nextcloud/server/issues/7615#issuecomment-386217515

blizzz commented 3 months ago

May I assume the app store was not reachable at the time of upgrade, hence user_saml could not be upgraded, ending up in this state.

blizzz commented 3 months ago

I am moving this to the server repository, as the saml backend is an unlucky victim.