nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.69k stars 4k forks source link

[Bug]: remote share items redirect to incorrect place #47618

Closed Antreesy closed 1 week ago

Antreesy commented 2 weeks ago

⚠️ This issue respects the following points: ⚠️

Bug description

Vue component props for remote shares are set incorrectly.

See response from API endpoint: image

And component props: image

Click on file redirects to /apps/files/files/2?dir=/&openfile=true instead of /apps/files/files/761?dir=/Shares&openfile=true

Steps to reproduce

  1. Set in Personal settings => Sharing => Set default folder for accepted shares => Set something different from /
  2. Accept remote share from federated server (try this to enable it) occ config:system:set sharing.federation.allowSelfSignedCertificates --value true --type bool occ config:system:set allow_local_remote_servers --value true --type bool
  3. Check that files appear in "Shared with you" and selected directory
  4. Try to navigate from "Shared with you" to it
  5. See result

Expected behavior

Items should redirect to mountpoint with correct (local) file_id to show a preview

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 28.0.1 to 28.0.2)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

Configuration report

No response

List of activated Apps

- cloud_federation_api: 1.11.0
 - federatedfilesharing: 1.18.0
 - federation: 1.18.0
 - files: 2.0.0
 - files_sharing: 1.20.0

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

Antreesy commented 2 weeks ago

cc @susnux as being discussed:

So either the frontend should also consider the file_id property (I think in sharing service?) or the backend for remote shares also should add the file_source property for consistency.