nextcloud / server

ā˜ļø Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.75k stars 4k forks source link

"New folder" icon is not color coded and thus confused with "Upload folder" #47921

Open jancborchardt opened 6 days ago

jancborchardt commented 6 days ago

How to use GitHub

Is your feature request related to a problem? Please describe. Got this issue report from @gerbrent: "Always when I open the "New" menu and want to create a new folder, I click on that one entry with the blue icon." Alas itā€™s the "Upload folder" function. image

Describe the solution you'd like Cause folders in the file list are blue, the "New folder" icon should also be blue.

Describe alternatives you've considered Making both icons grey/white, but then they are not as related to the folders anymore, so letā€™s not do that. Also, the sorting with upload functionality first is sort of standard, nothing we need to change there.

susnux commented 6 days ago

@jancborchardt what would be the correct fix:

  1. Also make the "new folder" primary color?
  2. Remove the primary color from "upload folder" and make the "new folder" primary?
1 2
Screenshot 2024-09-12 at 19-20-39 Files - Nextcloud Screenshot 2024-09-12 at 19-21-09 Files - Nextcloud
jancborchardt commented 6 days ago

@susnux I would have said also ā€“ now that you ask itā€™s also interesting how "New folder" is only blue cause that refers to a Nextcloud folder, while the upload refers to a non-Nextcloud folder.

I like both approaches. @susnux @gerbrent what do you think?

susnux commented 5 days ago
  1. Consistent design of folder icons, no special "focus"
  2. More focus on new-folder action

I do not have any preference here.

jancborchardt commented 5 days ago

@susnux looking at it again Iā€™d say letā€™s go with your solution 2, only coloring the "New folder" icon. The upload actions are only 2 and already grouped and also at the top, so they donā€™t really need focus.