nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.77k stars 4k forks source link

[Bug]: Misleading Error shown when file upload receives 403 #48164

Open grnd-alt opened 3 days ago

grnd-alt commented 3 days ago

⚠️ This issue respects the following points: ⚠️

Bug description

When uploading a file and the proxy has a file-filter rule in place to block the upload by sending a 403. Netflix UI says: Operation is blocked by access control indicating that it's the files_accesscontrol app who blocks

Error is caused by this line: https://github.com/nextcloud/server/blob/master/apps/files/src/views/FilesList.vue#L604 the server sends response content as well but it's only checked for the 403 code.

I know it's a very niche issue so LMK if that needs fixing.

Steps to reproduce

  1. block file uploads with proxy rule
  2. upload file
  3. see error Operation blocked by access control

Expected behavior

more clear error message

Nextcloud Server version

master

joshtrichards commented 10 hours ago

When uploading a file and the proxy has a file-filter rule in place to block the upload by sending a 403.

Can you elaborate this? What precisely are you doing on your reverse proxy?