search

nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.91k stars 4.02k forks source link

Show reason why group restriction not possible for that app #4864

Open MorrisJobke opened 7 years ago

MorrisJobke commented 7 years ago

Papercut from https://github.com/nextcloud/server/issues/2672

cc @eppfel @MariusBluem because you always asked for this

wiswedel commented 5 years ago

@MorrisJobke Is this still of interest or can it be closed? Can't there be several reasons - none of them giving the reader any practical benefit?

MorrisJobke commented 5 years ago

Can't there be several reasons - none of them giving the reader any practical benefit?

Yes there can be different and it would be helpful to communicate why given features are not there IMO.

szaimen commented 3 years ago

I am going to close this since there doesn't seem to be a lot of interest (no upvotes) and no respond since around 2 years. Please reopen if you still want to implement this.

joshtrichards commented 1 week ago

I suppose these are the reasons: https://github.com/nextcloud/server/blob/7ddad46137c17e3c272adbcf02ca29d7e8b2d6bd/apps/settings/src/mixins/AppManagement.js#L74-L82

https://github.com/nextcloud/server/blob/7ddad46137c17e3c272adbcf02ca29d7e8b2d6bd/apps/settings/src/components/AppStoreSidebar/AppDetailsTab.vue#L15

https://github.com/nextcloud/server/blob/7ddad46137c17e3c272adbcf02ca29d7e8b2d6bd/lib/private/App/AppManager.php#L35-L44

Apps this applies to:

https://github.com/search?q=org%3Anextcloud+path%3A%2F%28%5E%7C%5C%2F%29info%5C.xml%24%2F+filesystem+OR+prelogin+OR+authentication+OR+logging+OR+prevent_group_restrictions&type=code

For many (most?) of these it's somewhat obvious why they can't be limited. But I can see how a few might be surprising (e.g. Collectives, Photos, Maps, Community Document Server, Office Online, Activity).