nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
27.42k stars 4.07k forks source link

[stable28] fix: override iTip Broker to fix several issues #49269

Open backportbot[bot] opened 18 hours ago

backportbot[bot] commented 18 hours ago

Backport of #48583

Requires: https://github.com/nextcloud/server/pull/49267

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

kesselb commented 3 hours ago

Failing tests look related: https://drone.nextcloud.com/nextcloud/server/57857/9/4

image

SebastianKrupinski commented 3 hours ago

Failing tests look related: drone.nextcloud.com/nextcloud/server/57857/9/4

Yeah, I used a reflection trick to test the protected class, which seems to break with php 8.0. Might need to mod the test with a internal class and forward the request to the parent

kesselb commented 3 hours ago

Try invokePrivate from tests/lib/TestCase.php

SebastianKrupinski commented 2 hours ago

Try invokePrivate from tests/lib/TestCase.php

That worked! Thanks! Wish I knew about that when I created the test originally.