search

nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.75k stars 4k forks source link

Update jQuery to a supported version #6720

Open kittithorntha opened 6 years ago

kittithorntha commented 6 years ago

I have found that Nextcloud include jquery version 2.1.4 that have issue in this link https://github.com/jquery/jquery/issues/2432

https://github.com/nextcloud/server/blob/master/core/vendor/core.js at line 1 /*! jQuery v2.1.4 | (c) 2005, 2015 jQuery Foundation, Inc. | jquery.org/license */

Solution that is, Nextcloud should upgrade to the lasted version that was described in issue 2432

nickvergessen commented 6 years ago

The function which is dangerous is globalEval, and we fixed this method manually: https://github.com/nextcloud/server/blob/086ce709f7368af41543178a3de5d3c561b5ddb7/core/js/js.js#L1285-L1292

We should still think about updating it at some point since 2.1 seems to not get any updates anymore.

nickvergessen commented 6 years ago

cc @nextcloud/javascript

MorrisJobke commented 6 years ago

This requires #4628 to be fixed first.

juliushaertl commented 6 years ago

When greping through the core code, thw following in 3.x deprecated methods are also used quite often, so it makes sense to update those when bumping the jquery version:

lindhe commented 2 years ago

Is this why my web console is spammed with jQuery is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own.?

svrnhdl commented 2 years ago

Doing it for me too. Probably slowing down the load quite a bit I imagine?

Baccanno commented 2 years ago

Doing it for me too. Probably slowing down the load quite a bit I imagine?

Same for us, jquery is flooding and making th UI unresponsive. When I load the web UI with the DevTools open, everything is way more responsive. Very strange.

ogmkp commented 2 years ago

NC upgraded from 20 to 22 today and there are a lot of messages like that. This makes Chromium slow down. I consider this to be another regression. #31763