Integrity Error when upgrading to 13.0.beta4

leolivier commented 6 years ago

Steps to reproduce

select upgrade channel to 13.0.beta4
run the web installer

Expected behaviour

All steps are going to their end

Actual behaviour

Everything goes fine until downloading Then the integrity checks fails (with an http 503 error saying that the server is not available). I tried it 5 times (retry update) and 5 times the same error. I ran the upgrade manually (following https://docs.nextcloud.com/server/12/admin_manual/maintenance/manual_upgrade.html) with no problem at all. You can see the trace here: trace.txt After restarting the server, I still have an integrity warning in the security and configuration warnings

Server configuration

Operating system: Raspbian stretch

Web server: apache2.4.25

Database: mariadb 15.1

PHP version: 7.0.19

Nextcloud version: 13.0.beta4 Updated from an older Nextcloud/ownCloud or fresh install: from 12.0.4

Where did you install Nextcloud from: I used the zip downloaded by the web updater (the one on which the integrity checks failed)

Signing status:

Signing status

List of activated apps:

App list

``` Enabled: - activity: 2.6.1 - admin_notifications: 1.0.1 - audioplayer: 2.2.2 - bruteforcesettings: 1.0.3 - calendar: 1.5.7 - circles: 0.13.6 - comments: 1.3.0 - contacts: 2.0.1 - dav: 1.4.6 - federatedfilesharing: 1.3.1 - federation: 1.3.0 - files: 1.8.0 - files_external: 1.4.1 - files_markdown: 2.0.1 - files_pdfviewer: 1.2.0 - files_sharing: 1.5.0 - files_texteditor: 2.5.1 - files_trashbin: 1.3.0 - files_versions: 1.6.0 - files_videoplayer: 1.2.0 - firstrunwizard: 2.2.1 - gallery: 18.0.0 - groupfolders: 1.1.0 - logreader: 2.0.0 - lookup_server_connector: 1.1.0 - mail: 0.7.6 - nextcloud_announcements: 1.2.0 - notes: 2.3.2 - notifications: 2.1.2 - oauth2: 1.1.0 - password_policy: 1.3.0 - provisioning_api: 1.3.0 - serverinfo: 1.3.0 - sharebymail: 1.3.0 - socialsharing_email: 1.0.3 - survey_client: 1.1.0 - systemtags: 1.3.0 - theming: 1.4.1 - twofactor_backupcodes: 1.2.3 - updatenotification: 1.3.0 - workflowengine: 1.3.0 Disabled (mostly due to v13): - admin_audit - deck - drawio - encryption - files_accesscontrol - files_opds - keeweb - spreed - tasks - user_external - user_ldap ```

Nextcloud configuration:

Config report

``` { "system": { "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "nextcloud.levillain.fr.nf" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "overwrite.cli.url": "https:\/\/nextcloud.levillain.fr.nf", "dbtype": "mysql", "version": "13.0.0.9", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "maintenance": false, "memcache.local": "\\OC\\Memcache\\APCu", "htaccess.RewriteBase": "\/", "loglevel": 2, "updater.release.channel": "beta", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "php", "mail_smtpauthtype": "LOGIN", "mail_domain": "***REMOVED SENSITIVE VALUE***", "enabledPreviewProviders": [ "OC\\Preview\\Image", "OC\\Preview\\MP3", "OC\\Preview\\TXT", "OC\\Preview\\MarkDown", "OC\\Preview\\Epub", "OC\\Preview\\PDF" ], "updater.secret": "***REMOVED SENSITIVE VALUE***" } } ```

Are you using external storage, if yes which one: yes sftp

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Firefox 57

Operating system: Linux Mint 18.3 (sylvia)

Logs

Web server error log

Nothing at that moment in the error log In the access log: ``` 192.168.0.254 - - [06/Jan/2018:22:07:39 +0100] "GET /core/img/actions/info.svg?v=1 HTTP/2.0" 304 0 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0" 192.168.0.254 - - [06/Jan/2018:22:07:39 +0100] "GET /core/img/actions/triangle-s.svg HTTP/2.0" 304 0 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0" 192.168.0.254 - - [06/Jan/2018:22:07:42 +0100] "GET /core/img/actions/checkmark.svg?v=1 HTTP/2.0" 304 0 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0" 192.168.0.254 - - [06/Jan/2018:22:07:44 +0100] "GET /apps/updatenotification/credentials HTTP/2.0" 200 67 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0" 192.168.0.254 - - [06/Jan/2018:22:07:44 +0100] "POST /updater/ HTTP/2.0" 200 6622 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0" 192.168.0.254 - - [06/Jan/2018:22:07:51 +0100] "POST /updater/index.php HTTP/2.0" 200 36 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0" 192.168.0.254 - - [06/Jan/2018:22:07:51 +0100] "POST /updater/index.php HTTP/2.0" 200 36 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0" 192.168.0.254 - - [06/Jan/2018:22:07:51 +0100] "POST /updater/index.php HTTP/2.0" 200 36 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0" 192.168.0.254 - - [06/Jan/2018:22:07:58 +0100] "PROPFIND /remote.php/dav/files/Olivier/ HTTP/1.1" 503 1041 "-" "Mozilla/5.0 (Linux) mirall/2.3.3 (Nextcloud)" 192.168.0.254 - - [06/Jan/2018:22:08:27 +0100] "PROPFIND /remote.php/dav/files/Olivier/ HTTP/1.1" 503 4463 "-" "Mozilla/5.0 (Linux) mirall/2.3.3 (Nextcloud)" 192.168.0.254 - - [06/Jan/2018:22:08:28 +0100] "PROPFIND /remote.php/dav/files/Olivier/ HTTP/1.1" 503 1041 "-" "Mozilla/5.0 (Linux) mirall/2.3.3 (Nextcloud)" 192.168.0.254 - - [06/Jan/2018:22:07:52 +0100] "POST /updater/index.php HTTP/2.0" 200 36 "-" "Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0" 192.168.0.254 - - [06/Jan/2018:22:08:59 +0100] "GET /status.php HTTP/1.1" 200 4736 "-" "Mozilla/5.0 (Linux) mirall/2.3.3 (Nextcloud)" ```

Nextcloud log (data/nextcloud.log)

updater.log nextcloud.log

Browser log

``` Insert your browser log here, this could for example include: a) The javascript console log b) The network log c) ... ```

MorrisJobke commented 6 years ago

dav

EXTRA_FILE

appinfo/database.xml

lib/CardDAV/SyncJob.php

Weird - this looks like #7644 but it is definitely included in the beta 4 and should also be properly signed.

@rullzer @nickvergessen Do you have an idea how the signature could be messed up like this.

After restarting the server, I still have an integrity warning in the security and configuration warnings

That sounds like some caching issue in the PHP opcache, that is setup for too long.

rullzer commented 6 years ago

@MorrisJobke I'm very confused here.

Because https://github.com/nextcloud/server/tree/v13.0.0beta4/apps/dav/lib/CardDAV doesn't show the SyncJob.php

Also my private instance doesn't have the extra file (while it downloads the same tarball I assume).

rullzer commented 6 years ago

Aaaah no my bad... I should look into the right folder....

@leolivier did you follow the steps in https://docs.nextcloud.com/server/12/admin_manual/maintenance/manual_upgrade.html ? Or did you unpack your new installation in place. Because unpacking in place would cause the files to still be there...

leolivier commented 6 years ago

Hi @rullzer As mentioned in my description, I first tried with the web updater which failed. Then I followed almost exactly the manual upgrade description (ie renaming the previous nextcloud directory before unpacking)

MorrisJobke commented 6 years ago

Weird - this looks like #7644 but it is definitely included in the beta 4 and should also be properly signed.

Now it makes sense: It looks like the old code was not deleted but the new code was copied over.

@leolivier Did you delete all the files before extracting the new code?

MorrisJobke commented 6 years ago

As mentioned in my description, I first tried with the web updater which failed.

Why did it failed? (see the updater.log in your data dir)

leolivier commented 6 years ago

@MorrisJobke, I don't understand what you mean. When I used the web upgrade, I don't know what the upgrader does, this is entirely managed by nc. For the manual part, I renamed the dir before unpacking so I didn't write the new code above the old one... I linked the updater.log file in my first post

MorrisJobke commented 6 years ago

I linked the updater.log file in my first post

Ah - it was hidden behind a folded entry, because of a syntax issue.

leolivier commented 6 years ago

It seems that my first post has a formatting issue, I can't see the updater.log file but I'm not able to link it now...

nickvergessen commented 6 years ago

https://github.com/nextcloud/server/tree/v13.0.0beta4/apps/dav/appinfo

Dav also has no database.xml anymore, so signing is all good, and there seems to just be an additional file on disk.

MorrisJobke commented 6 years ago

Dav also has no database.xml anymore, so signing is all good, and there seems to just be an additional file on disk.

As we cannot reproduce this, there seems to be a different way how those files came there. They are neither in the zip nor in the tar ball. Just remove them and run the integrity check again. This should fix the issue for you.

I will close this here. Maybe somebody else runs into the same issues and then we can look if we could nail down the reason for this.

Thanks

leolivier commented 6 years ago

Ok for closing but I insist that this was totally managed by the web automatic upgrader at the beginning and thus if the files are here, they've been put there by itself...

MorrisJobke commented 6 years ago

Sadly I'm out of ideas how this could happen. The updater in it's fundamentals of copying files wasn't touched since quite some time and many many updates have been made with it, without showing this behaviour. Sorry :/

leolivier commented 6 years ago

FYI, I just upgraded from beta4 to RC1 with the auto updater without any problem.

rullzer commented 6 years ago

Then lets just hope it was a one time error :)

leolivier commented 6 years ago

Hi I got the same problem while upgrading from rc1 to rc2 ☹️

leolivier commented 6 years ago

The web auto update says:

Verifying integrity
Parsing response failed. <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> <html><head> <title>503 Service Unavailable</title> </head><body> <h1>Service Unavailable</h1> <p>The server is temporarily unable to service your request due to maintenance downtime or capacity problems. Please try again later.</p> <hr> <address>Apache/2.4.25 (Raspbian) Server at nextcloud.levillain.fr.nf Port 443</address> </body></html>

Content of updater.log shoes nothing except it ends after downloading:

pi@raspberrypi /data/nextcloud $ tail -50 updater.log
2018-01-18T21:15:41+0100 9nkTvNfiqg [info] startStep("2")
2018-01-18T21:15:41+0100 9nkTvNfiqg [info] checkWritePermissions()
2018-01-18T21:15:41+0100 9nkTvNfiqg [info] end of checkWritePermissions()
2018-01-18T21:15:41+0100 9nkTvNfiqg [info] endStep("2")
2018-01-18T21:15:41+0100 jtKQ2PVQSI [info] request to updater
2018-01-18T21:15:41+0100 jtKQ2PVQSI [info] currentStep()
2018-01-18T21:15:41+0100 jtKQ2PVQSI [info] Step 2 is in state "end".
2018-01-18T21:15:41+0100 jtKQ2PVQSI [info] POST request for step "3"
2018-01-18T21:15:41+0100 jtKQ2PVQSI [info] startStep("3")
2018-01-18T21:15:41+0100 jtKQ2PVQSI [info] setMaintenanceMode("true")
2018-01-18T21:15:41+0100 jtKQ2PVQSI [info] configFileName /var/www/nextcloud/updater/../config/config.php
2018-01-18T21:15:41+0100 jtKQ2PVQSI [info] end of setMaintenanceMode()
2018-01-18T21:15:41+0100 jtKQ2PVQSI [info] endStep("3")
2018-01-18T21:15:41+0100 8xtMIpN3AK [info] request to updater
2018-01-18T21:15:41+0100 8xtMIpN3AK [info] currentStep()
2018-01-18T21:15:41+0100 8xtMIpN3AK [info] Step 3 is in state "end".
2018-01-18T21:15:41+0100 8xtMIpN3AK [info] POST request for step "4"
2018-01-18T21:15:42+0100 8xtMIpN3AK [info] startStep("4")
2018-01-18T21:15:42+0100 8xtMIpN3AK [info] createBackup()
2018-01-18T21:16:41+0100 8xtMIpN3AK [info] end of createBackup()
2018-01-18T21:16:41+0100 8xtMIpN3AK [info] endStep("4")
2018-01-18T21:16:42+0100 KyLCxsRJjV [info] request to updater
2018-01-18T21:16:42+0100 KyLCxsRJjV [info] currentStep()
2018-01-18T21:16:42+0100 KyLCxsRJjV [info] Step 4 is in state "end".
2018-01-18T21:16:42+0100 KyLCxsRJjV [info] POST request for step "5"
2018-01-18T21:16:42+0100 KyLCxsRJjV [info] startStep("5")
2018-01-18T21:16:42+0100 KyLCxsRJjV [info] downloadUpdate()
2018-01-18T21:16:42+0100 KyLCxsRJjV [info] getUpdateServerResponse()
2018-01-18T21:16:42+0100 KyLCxsRJjV [info] updaterServer: https://updates.nextcloud.org/updater_server/
2018-01-18T21:16:42+0100 KyLCxsRJjV [info] releaseChannel: beta
2018-01-18T21:16:42+0100 KyLCxsRJjV [info] internal version: 13.0.0.10
2018-01-18T21:16:42+0100 KyLCxsRJjV [info] updateURL: https://updates.nextcloud.org/updater_server/?version=13x0x0x10xxxbetaxx2018-01-11T19%3A40%3A31%2B00%3A00+4f30c2fbe43e0d6f24ba3bff881526b2b6c2747dx7x0x19
2018-01-18T21:16:42+0100 KyLCxsRJjV [info] getUpdateServerResponse response: Array
(
    [version] => 13.0.0.11
    [versionstring] => Nextcloud 13.0.0 RC 2
    [url] => https://download.nextcloud.com/server/prereleases/nextcloud-13.0.0RC2.zip
    [web] => https://docs.nextcloud.com/server/12/admin_manual/maintenance/upgrade.html
    [autoupdater] => 1
    [signature] => Nr+b4svVD6Y//JQKMiRn/VSYZrTlPpdQ+3oOYVR1VFrc9ZZr0SIV9/VxDHL6prbTGRGSiMNBogq+mj12KC243w7TBOBT5x3zlEhbysHuNScAsKeAMf5dRlUFBb7klMEr
9gw+Q6B57XsVHT4lxEDgLrOVsQxuuXX39tVYZi4H+Abob/VBXnBwwFXgBYKUahkx
k8ZZNFeeXmvbIq4VcUoe3yg+dC7OpfVh6rEvlMlDLumGxk4Ht9gMP2fNeQvqOhib
oxxOER2kH0ATEBCOsVHSMBruViAkjltOBPCSoZY+j+ggjj9wjBEjbetGepXkSgtI
3N03uA/njV2Yx08qBHk+JQ==
)

2018-01-18T21:16:42+0100 KyLCxsRJjV [info] storage location exists
2018-01-18T21:25:13+0100 KyLCxsRJjV [info] end of downloadUpdate()
2018-01-18T21:25:13+0100 KyLCxsRJjV [info] endStep("5")

rullzer commented 6 years ago

@MorrisJobke

MorrisJobke commented 6 years ago

Verifying integrity Parsing response failed.

Looks weird - the response is a 500 error. Could you also check the webserver logs (especially the error log) and if available the PHP log (only in a php-fpm env available)?

leolivier commented 6 years ago

As last time, I finally upgraded manually following closely the described procedure. It worked but when I go to the application, I get a warning message about integrity and the errors are on audioplayer:


Technical information ===================== The following list covers which files have failed the integrity check. Please read the previous linked documentation to learn more about the errors and how to fix them. Results ======= - audioplayer - EXCEPTION - OC\IntegrityCheck\Exceptions\InvalidSignatureException - Certificate is not valid. Raw output ========== Array ( [audioplayer] => Array ( [EXCEPTION] => Array ( [class] => OC\IntegrityCheck\Exceptions\InvalidSignatureException [message] => Certificate is not valid. ) ) )

leolivier commented 6 years ago

Hello The 503 error was the same last time, if you re read the beginning of this thread. And I did'nt find anything special in the Apache error's log at that time. I'll check it later in the day, no access now.

nextcloud-bot commented 6 years ago

Hey, this issue has been closed because the label stale is set and there were no updates for 14 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

nextcloud / server