Closed blizzz closed 4 months ago
It should also be visible in the actual place of the app. I guess no one looks for new features in the personal section.
When a talk update was done, the info should be displayed as soon as the user visits index.php/apps/spreed the first time.
Of course this needs to be done by the app itself, I would say we should just provide a frame work how to do this, for displaying something like the first-run-wizzard is something I could imagine.
The idea, as discssed with @jancborchardt, was to have as little interruption to the user as possible. That's why we did not go for notifications, for instance. Some apps may have not a page of their own (e.g. impersonate, e2ee, checksum), for others a common approach is not really feasible (richdocuments, various viewers).
As ^ was discussed further on IRC, the takeaways: personally I am not convinced, anyhow opinions on this matter drift to different directions. Imho, we should go with this approach. Later, still something like a reusable Vue component can be offered to display an indicator on an app about news (not a popup). The risk of misuse for unimportant changes is there, but apps could do this already by their own implementations either way.
A user-facing thing we could do is something in the left #app-navigation. Like a container which can be closed via an x icon in the top right. Similar to what https://github.com shows in the top right when you are logged in (will do a screenshot when they show news again).
(will do a screenshot when they show news again).
 in the info.xml the app developer will be able to optionally specify a link to a changelog page.
We could also just used the changelog from the app store for that, since the store parses CHANGELOG.md files in the release bundles if they are available.
when an app update is available, below the "Update to x.y" button a "What's new?" text is shown. On click a popup is shown with that info (if given, a placeholder text otherwise), and a link to the changelog (if provided). If neither are provided, the "What's new?" label is not shown.
A "What's new" section on the personal settings shows the same short info (with version and date) after update. Entries only younger than 3(?) months will be shown there, older ones are expunged.
I would probably break this into two parts, admin related changelog (in the apps management) and a user related changelog as @jancborchardt suggested (in the app itself)
We could also just used the changelog from the app store for that, since the store parses CHANGELOG.md files in the release bundles if they are available.
Interesting aspect. However, sometimes the md file is not present, or worse outdated.
The advantage would be that we can show it inline and do not require the user to open another website. The mock would need to be extended to reflect that @jancborchardt
I would probably break this into two parts, admin related changelog (in the apps management) and a user related changelog as @jancborchardt suggested (in the app itself)
@jancborchardt would be two sorts of "what's new" notification, same discussion for the server part. Especially for later I need a decision sooner than later. Makes sense imho. Your call.
For sure a good idea to break it into two parts. The first part to implement is the admin side of course. But having it on the user side is also needed further down the line.
@blizzz what do you mean by that it needs to be extended to reflect that? Even if a changelog.md is present, I would say we cut it max to the first 3 lines, and encourage people to summarize it in max 3 points (more can be below of course).
@blizzz what do you mean by that it needs to be extended to reflect that? Even if a changelog.md is present, I would say we cut it max to the first 3 lines, and encourage people to summarize it in max 3 points (more can be below of course).
@jancborchardt it's about the link for the changelog, not for the shown 3-line content. The changelog would not to be suited for this.
For sure a good idea to break it into two parts. The first part to implement is the admin side of course. But having it on the user side is also needed further down the line.
So: separate content for end users and for admins.
@blizzz oh sorry, that was a misunderstanding: By splitting into two parts I meant only the code, not the content. I don’t necessarily think we need separate 3 changelog points for admins and users. That will double the workload of app developers, and I don’t see the reason why the messages should be any different. Admins are users too?
The thought behind is that for admins it makes sense if some behaviour changed, setting was added, manual operation is necessary, while this is all irrelevant for end users.
We had a discussion today with @jancborchardt and @MorrisJobke
vue component for presenting the info in a box absolutely positioned in the lower left corner
I thought lower right, but in the end it shouldn’t matter that much 😅
that's were in most cases the sidebar is, and the first idea was to put it into it.
Another question that comes to my mind, what to do with it on mobile view? Not showing at all? Would tend to it, unless, i guess in some places / for some people it might not be so uncommon to operate with mobile devices only.
It seems that this one will not make it to 14, right? Move to 15?
Yes, no way to get it done in time, sadly.
So in the end, is this done?
This one is for apps - #10050 is the changelog of the server for users. ;)
Arf, sorry :)
Updated description according to https://github.com/nextcloud/server/issues/9165#issuecomment-395445072
@blizzz It seems this didn't made it -> moving to 16.
Let's move it to 17.
Was just about to add this feature request :) It would be great to have a short changelog directly in the app list/details.
any news about this? i see it's added to version 17.0.3 will it be included in that version or do you expect to have it in a later version?
As an update, for users this might be nice for each Nextcloud version, like the firstrunwizard. It could be a simplified version of the release post with a link to the full one included.
So I thought about multiple ways how to solve this. I came up with three solutions:
My thoughts on the solutions above:
Here is the mockup that I've created. It should be the first page after the introduction video, before the A collaboration platform slide
. The firstrunwizard should then open always for each user once after a minor or major update:
cc @nextcloud/designers WDYT? :)
We could also just used the changelog from the app store for that, since the store parses CHANGELOG.md files in the release bundles if they are available.
I would back this, we already parse changelog.md which is pretty standard. So as an app maintainer I would not be happy to have a new file (changes.xml
) to also maintain for the same purpose.
@szaimen yeah, the option like the first run wizard seems the best.
- It would best be a separate modal though. "What's new" instead of "Info". People don't want to click through the first run wizard stuff every release :)
I disagree but lets discuss this tomorrow in our design call. It can definitely be part of it if it is the first slide after the video imho :)
- As said above: "It could be a simplified version of the release post with a link to the full one included." – we should much rather do that than paste a changelog. Remember this will be seen by each and every single user, so it's important it goes through editing by marketing @jospoortvliet @cartierbresson
Yeah that would indeed make sense
- We can then have 3 slides for "What's new" as well. 1st for the short info like the tweet, 2nd for the video for example, 3rd for additional links like full blog, tweet, toot, etc.
Not sure about that yet. Could also talk about it tomorrow in the call :)
@jancborchardt that then sounds like something for "Hub"/shipped things only.
The idea from back then was an option to have this available for everyone. So also other "bigger" apps like Forms, cookbooks, etc. could show case their stuff to users when publishing their major (not aligned with Nextcloud Hub releases).
I would back this, we already parse changelog.md which is pretty standard. So as an app maintainer I would not be happy to have a new file (changes.xml) to also maintain for the same purpose.
@susnux as per above, this is something very different from changelog.md at least for me. In Talk on a major we have 3 blocks (user, admin, developers) with multiple items each. But we definitely would not want to show all of them prominent like this in the modal. But instead of some them should be there, maybe with a bit more explanation and a screenshot or something.
@nickvergessen yep, but as always we need to start somewhere. :)
Showing a whole changelog, even just max. 3 entries for each app will be unwieldy. There needs to be some editing, especially since this will be shown to every single account.
And we do these great keynotes incl video and social media messaging, so it would be a shame to not re-use this. :)
I think Jan's proposal is entirely usable.
The content of the first pane (or all 3) can be delivered by marketing, I think (we'll have to sync with Jocelyne ofc but I doubt it's an issue). I like the 1 pane text (and image, pls?), 1 pane video, 1 pane 'links to read more' approach.
There's one concern I have: when the user clicks it away (maybe because they are in a hurry right now) there should be a way to get the dialog back. Perhaps there should be a notification, too, which brings up the dialog. Then you can bring it back upon demand. Or, as notifications are ofc also not persistent, it should after the first time follow the about dialog...
There's one concern I have: when the user clicks it away (maybe because they are in a hurry right now) there should be a way to get the dialog back.
this is one of the reasons why I would it as additional pages into the firstrunwizard :)
There's one concern I have: when the user clicks it away (maybe because they are in a hurry right now) there should be a way to get the dialog back.
this is one of the reasons why I would it as additional pages into the firstrunwizard :)
@szaimen this is why in our call I mentioned to have an entry "What's new" in the account menu, right below the "About" entry which triggers the firstrunwizard. ;)
It makes sense to separate this. :)
It makes sense to separate this. :)
I still disagree. But ss I said, lets discuss this tomorrow in our call :)
So if I get it right, this is now scoped to a "whats new in this hub version"? This dialog is shown instead of the first run wizard if the wizard was already shown - meaning on every update?
So the initial feature request is descoped here, as it was about administrator information "whats new in this app version, so should I update?". And is now a "whats new in this release - what can I now use".
But then this dialog will be bound to core- or shipped-apps as 3rd party apps like forms are updated also between hub releases.
Good point. Since I am still working on a mockup, i might try to address this point as well if time allows.
I now created a mockup, first for new Hub releases. Currently under review by the Design team. Will let you know as soon as I have their feedback
Here is now my final mockup:
Mockups |
---|
Please let me know if you have any feedback or question :)
admins should have a brief info on what's new in an available app release
This is implemented already, admins can look at the "changelog" appsidebar tab of the app details.
For users apps currently have to provide their own dialog (like talk is doing).
To add to the current scope, these requirements must be met additionaly:
^ should be about this app
^ should be about this app
Think this is about #42547 (And currently just a placeholder)
Unbinding from the feature that was delivered and reopening, as (not-shipped) apps still don't have an option to provide a changelog
Unbinding from the feature that was delivered and reopening, as (not-shipped) apps still don't have an option to provide a changelog
They have. Implemented in https://github.com/nextcloud/server/pull/43967 Documentation on how to use it: https://docs.nextcloud.com/server/latest/developer_manual/app_development/info.html#changelog
Users and admins should have a brief info on what's new in an available app release, and the possibility to have a direct link to a Changelog.
Appeareance on the apps management:
Mockups by @jancborchardt