search

nextcloud / server

☁️ Nextcloud server, a safe home for all your data
https://nextcloud.com
GNU Affero General Public License v3.0
26.77k stars 4k forks source link

Deactivated users should not be suggested in chat/comments mentions and on the sharee endpoint. #9948

Open nickvergessen opened 6 years ago

nickvergessen commented 6 years ago

See https://github.com/nextcloud/spreed/issues/959

Or does anyone know a reason why they should? @MorrisJobke @blizzz

nextcloud-bot commented 6 years ago

GitMate.io thinks possibly related issues are https://github.com/nextcloud/server/issues/6755 (Disabled users should not be suggested in the sharee dialog), https://github.com/nextcloud/server/issues/4555 (Mentioned user not clickable after posting a comment), https://github.com/nextcloud/server/issues/753 (user mentions in comments), https://github.com/nextcloud/server/issues/6038 (User shouldn't be shown in contactlist if the account is deactivated), and https://github.com/nextcloud/server/issues/2443 (Missing pieces: user mentions in Comments).

MorrisJobke commented 6 years ago

Those two are the counter parts for contact list and share dialog:

6755 (Disabled users should not be suggested in the sharee dialog)

6038 (User shouldn't be shown in contactlist if the account is deactivated)

diplodata commented 6 years ago

Also it should not be possible to initiate a Talk conversation with a disabled user. At present you can, by clicking on the Talk to x button in the Search contacts dropdown list - a new chat thread appears in Talk and there is no notification that the other user is disabled.

nickvergessen commented 6 years ago

@diplodata that is the same issue. It's all using the same endpoint ;)

szaimen commented 3 years ago

I suppose this issue is still valid? If not, please close this issue!

blizzz commented 3 years ago

Disabling users was designed to only reject them logging in. If we want this to change, we ought to write a comprehensive concept describing what the consequences shall be generally, not just about a single point.

szaimen commented 1 year ago

Hi, please update to 24.0.8 or better 25.0.2 and report back if it fixes the issue. Thank you!

nickvergessen commented 1 year ago

Still an issue

nickvergessen commented 1 year ago

But maybe bug is the wrong label. It's more of a discussion field of what the scope is and to clarify it. Currently it fails to match 90% of the user expectations.

szaimen commented 1 year ago

then lets use a different label :)