search

nextcloud / serverinfo

📊 A monitoring app which creates a server info dashboard for admins
GNU Affero General Public License v3.0
94 stars 61 forks source link

fix: Display threads and not cores #658

Closed provokateurin closed 1 month ago

provokateurin commented 1 month ago

For Linux I verified this is correct, but I'm not able to test this on FreeBSD. I'm relatively sure though that the variable that is read is also the thread count and not the core count. While trying to find documentation for the sysctl variable I read https://man.freebsd.org/cgi/man.cgi?smp(4) and it seems we should switch to hw.ncpu since that is at least documented (and if I understood correctly it is also the thread count and not the core count). On that note it might be nice to show both the number of threads and cores and not only one of them. FreeBSD also has some other variables related to threads per core, but with the recent changes on processor topologies it seems worthless to me to use that since not every core is guaranteed to have the same number of threads...

provokateurin commented 1 month ago

/backport to stable29

provokateurin commented 1 month ago

/backport to stable28