nextcloud / social

🎉 Social can be used for work, or to connect to the fediverse!
https://apps.nextcloud.com/apps/social
GNU Affero General Public License v3.0
488 stars 59 forks source link

webfinger returning URL without https #1091

Open haraldh opened 3 years ago

haraldh commented 3 years ago

Describe the bug webfinger returning http instead of https

To Reproduce Steps to reproduce the behavior:

$ curl -L -H "Accept: application/ld+json" -X GET https://hoyer.xyz/nextcloud/index.php/apps/social/@harald | jq
{
  "@context": [
    "https://www.w3.org/ns/activitystreams",
    "https://w3id.org/security/v1"
  ],
  "id": "http://hoyer.xyz/nextcloud/nextcloud/index.php/apps/social/@harald",
  "type": "Person",
  "url": "http://hoyer.xyz/nextcloud/nextcloud/index.php/apps/social/@harald",
  "icon": {
    "id": "http://hoyer.xyz/nextcloud/index.php/documents/avatar/16444d2f-290f-40e6-9ba5-d5b082bf127b",
    "type": "Image",
    "url": "https://hoyer.xyz/nextcloud/index.php/avatar/harald/128",
    "mediaType": "",
    "mimeType": "",
    "localCopy": "avatar",
    "resizedCopy": ""
  },
  "local": true,
  "aliases": [
    "@harald",
    "users/harald"
  ],
  "preferredUsername": "harald",
  "name": "Harald Hoyer",
  "inbox": "http://hoyer.xyz/nextcloud/nextcloud/index.php/apps/social/@harald/inbox",
  "outbox": "http://hoyer.xyz/nextcloud/nextcloud/index.php/apps/social/@harald/outbox",
  "account": "harald@hoyer.xyz",
  "following": "http://hoyer.xyz/nextcloud/nextcloud/index.php/apps/social/@harald/following",
  "followers": "http://hoyer.xyz/nextcloud/nextcloud/index.php/apps/social/@harald/followers",
  "endpoints": {
    "sharedInbox": "https://hoyer.xyz/nextcloud/index.php/apps/social/inbox"
  },
  "publicKey": {
    "id": "http://hoyer.xyz/nextcloud/nextcloud/index.php/apps/social/@harald#main-key",
    "owner": "http://hoyer.xyz/nextcloud/nextcloud/index.php/apps/social/@harald",
    "publicKeyPem": "-----BEGIN PUBLIC KEY-----\nMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAz/pKrIcPiKjX2OHi5Uc3\nZR7mNagnOwc5tGvr/XyqG4O4hkewLY+xf2rZZgTSqJLFDJlDjIIxChQmAi7TjqMJ\nN+6NLSydKcv1fhW3VCtMOAMCg7JAxsU/f5NjEFUwZetTu6iuCm3K0NtCgzEEj/1H\n93Afq9BjS+Owgor85AIzi7opyv6jWWI64scEdc+W3NKjrVYmrxSv2FTHfMA2rDo2\nwM4qkVMYzDtaqD/MnRmFW06ihgBFVzHTQquU7RXQ1nQeqLa3Te61cToBNc4BJLr/\nYRepBU4xA2ikCxwl8c0FL85B6iOjDO07bXnbt1KCyiw6D572lXx83eg8xhPDe3RQ\n9wIDAQAB\n-----END PUBLIC KEY-----\n"
  }
}

Expected behavior see https in the json everywhere

social version v0.4.1

mnd commented 3 years ago

@haraldh can you check output of the occ social:check:install command? I think that you have "social_url": "http:\/\/hoyer.xyz\/nextcloud\/nextcloud\/index.php\/apps\/social" in your configuration.

I do not know how to configure it in correct manner, but you can try to change URL during occ social:reset command. NOTE: This command will remove all your Nextcloud Social data.

haraldh commented 3 years ago

@haraldh can you check output of the occ social:check:install command? I think that you have "social_url": "http:\/\/hoyer.xyz\/nextcloud\/nextcloud\/index.php\/apps\/social" in your configuration.

yes, it was, and I set it to the correct url, but it didn't change anything

I do not know how to configure it in correct manner, but you can try to change URL during occ social:reset command. NOTE: This command will remove all your Nextcloud Social data.

I had to disable the social module completely, because of https://github.com/nextcloud/social/issues/1092