search

nextcloud / socialsharing

🐦 Social sharing via Facebook, Twitter & more
https://github.com/nextcloud-releases/socialsharing
GNU Affero General Public License v3.0
25 stars 15 forks source link

Release 3.0.0 points to an out-of-branch commit and builds don't match the code #76

Closed nextcloud486153 closed 7 months ago

nextcloud486153 commented 8 months ago

Hi there,

I just tried to download and install the latest release (3.0.0) from source (the .tar.gz source bundle offered by GitHub) and socialsharing_telegram does not work (I've run make appstore to generate the installable app).

On closer inspection, I see two potential problems:

  1. The release points to a commit that is not in any branch of this repo (567214e395e3be9d9e183dabbf963636d695fa97). There is a commit with the same message, but different hash on the master branch (4562581135368eaa1eb33b45fd183eca00f34171).
  2. The pre-built apps contain some files that do not appear in the release commit (567214e), such as:
    • socialsharing_telegram/js/socialsharingtelegram.js
    • socialsharing_telegram/css/socialsharingtelegram.css
    • socialsharing_telegram/css/socialsharing_telegram.css differs (the pre-builts include media and dark theme selectors).

Would it be possible to create a new release in which the pre-builts and the output of make appstore in the sources match?

Thank you for your efforts on making Nextcloud better :D

nextcloud486153 commented 7 months ago

There is a new release live (3.0.1), so that solves the problem.