Display name is "null" after reload from being logged out - Githubissues

nextcloud / spreed

🗨️ Nextcloud Talk – chat, video & audio calls for Nextcloud

https://nextcloud.com/talk

GNU Affero General Public License v3.0

1.63k stars 436 forks source link

Display name is "null" after reload from being logged out #10535

Open fancycode opened 1 year ago

fancycode commented 1 year ago

How to use GitHub

Please use the 👍 reaction to show that you are affected by the same issue.
Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
Subscribe to receive notifications on status change and new comments.

Steps to reproduce

Be in a room with a user account and close your laptop over night.
Have your session expire while laptop is closed.
Open your laptop, notice your signaling connection is not reconnected automatically and reload the page (now as anonymous guest user).

Expected behaviour

Display name should have a sensible default value.

Actual behaviour

displayname_null

Experienced on c.n.c in the Talk development room.

nickvergessen commented 1 year ago

cc @DorraJaouad since you touched the guest names ~~maybe for https://github.com/nextcloud/spreed/pull/10467~~ - master only

UPD.: this could be triggers for this issue:

https://github.com/nextcloud/spreed/pull/10475 touched store
https://github.com/nextcloud/spreed/pull/10301 touched BrowserStorage

DorraJaouad commented 1 year ago

There is a "Guest" string as a fallback if the getter getDisplayName() returns null. Will be further checking ...