Antreesy
commented
1 year ago - [ ] Breakout rooms session should be closed when the moderator wants to toggle the consent requirement in the conversation settings . It renders Bad request otherwise ( maybe add a hint in toast ? )
- [ ] Leaving the call or the conversation should update the sidebar and remove the call view and the chat and show This conversation has ended
with internal signling only, we fetch conversation within an interval, and show context you mentioned. but with HPB it wait for signaling message. It seems like when the share owner leaves conversation, it's removed on server side. So, we may track signaling message, that owner left the room, and fetch the conversation within some timeout => and if it was deleted, all should go back to normal => will raise a follow-up issue
A minor detail: when the device selector is shown in request password/video verification clicking on Always show preview for this conversation or in the menu to start a silent call has no effect (the checkbox is not modified, and the menu is not opened).
Nevertheless, those options should not be even visible, because every time a password is requested again a new room will be created, so there is no point in remembering Always show preview for this conversation, and the call should not be silently started, as the owner of the file should be notified that a password is being requested.
Originally posted by @danxuliu in https://github.com/nextcloud/spreed/pull/10633#pullrequestreview-1691692030