Only show out of office message when applicable

nickvergessen commented 1 year ago

How to use GitHub

Please use the 👍 reaction to show that you are affected by the same issue.
Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
Subscribe to receive notifications on status change and new comments.

Steps to reproduce

Set up OOO for upcoming (not current!) vacation 24th Dec to 8th Jan
Have DND user status (availability or manual)

Expected behaviour

Nothing happens

Actual behaviour

Bildschirmfoto vom 2023-11-30 22-34-39

THe OOO api endpoint returns start and end time. We should check it before displaying.

Talk app

Talk app version: main

Antreesy commented 1 year ago

Isn't it possible to expose status message id on that stage? Acting on 'dnd' here is firing cannons at sparrows

nickvergessen commented 1 year ago

Isn't it possible to expose status message id on that stage?

Not really, due to bad architectural decisions back then the user status is one of the worst code/API we have atm with way too many layers and abstractions in-between (2 different models pass the data through 3 services and managers...).

It's not worth breaking at this stage of the server release (11 days left). So let's just add a check for the time before displaying the message from OOO

nextcloud / spreed