nextcloud / spreed

🗨️ Nextcloud Talk – chat, video & audio calls for Nextcloud
https://nextcloud.com/talk
GNU Affero General Public License v3.0
1.64k stars 437 forks source link

Groups with special Character can not be addressed #11935

Open xbluemonkx opened 7 months ago

xbluemonkx commented 7 months ago

Steps to reproduce

  1. Create a user group, that has a Special Charakter in it (Umlaute: äöü) (eg: "Bälle" - german word for "Balls")
  2. Add this group to a chat
  3. reference the group in a message using @group (@Bälle)

Expected behaviour

it should work like it works with users or groups without special character. The group should be converted into that visual icon of the group.

Actual behaviour

Message looks like this: "Hello Friends of @"group/Bälle" can someone please call me?"

Talk app

Talk 18.0.5 Nextcloud 28.0.3 Firefox

nickvergessen commented 7 months ago

Yeah the server code only supports a-zA-Z0-9 at the moment for the group IDs: https://github.com/nextcloud/server/blob/e5b0c06b2449d9015ed1ce5d0fd027836babc939/lib/private/Comments/Comment.php#L223

However you could create a group Baelle with the displayname Bälle:

occ  group:add --help
Description:
  Add a group

Usage:
  group:add [options] [--] <groupid>

Arguments:
  groupid                          Group id

Options:
      --display-name=DISPLAY-NAME  Group name used in the web UI (can contain any characters)

At least on CLI the option is easily accessible.

In the web you would need to create the group as Baelle and then rename it afterwards.

xbluemonkx commented 7 months ago

Hi @nickvergessen,

thanks for the input. this bug is anoying, but not critical. therefore we will just live with it until there is a fix in the server code.

but the workaround looks good and I am glad you wrote it down. maybe someone else will use it.