⛔ Banning users and guests - API

[nickvergessen]

• Overview at https://github.com/nextcloud/spreed/issues/12291

---

• [x] Deliver contract up front https://github.com/nextcloud/spreed/pull/12259
• [x] Implement database model
• [x] Implement Blocking the join
• [x] Add integration tests
• [x] https://github.com/nextcloud/spreed/issues/12670

[SystemKeeper]

• RequireModeratorParticipant is also true for 1:1 conversations. Do we allow blocking in 1:1 ?
• Does internalNote has a maximum length we need to enforce?
• We do have the information actorType and actorId about the person that did add the ban. Should we also include the actorDisplayname? Otherwise we can only show the actorId to the user, which might be weird (e.g. LDAP). Same probably for the banned participant in case we can determine a displayname?
• Do we allow to directly ban an IP? According to the contract, this would be possible by specifying ip as actorType. Since we don't know the IP of any of the participants, I am not sure this is correct? https://github.com/nextcloud/spreed/blob/3cda633a5f019c0f47a88bfc12b6e90e49ec5bee/lib/Controller/BanController.php#L36

Answers see: https://github.com/nextcloud/spreed/issues/12291#issuecomment-2107001375

[nickvergessen]

Answered in https://github.com/nextcloud/spreed/issues/12291

[nickvergessen]

• [x] Banning an IP does not validate the actorId to be a valid IP @nickvergessen
• [x] Banned IP ranges are not checked against guest IPs @nickvergessen

---

• Contributed to the API from https://github.com/nextcloud/server/pull/46473 to allow this