Limit to groups in federated target server breaks federation

[pmarini-nc]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Steps to reproduce

1. Admin of nc2 enables federation and sets the following settings: user2 is both in groups admin and general.
2. user1@nc1 invites user2@nc2 into a federated conversation

Expected behaviour

Successful creation of a federated conversation. Limit to groups should limit the possibility to invite, not to be invited and in any case user2 is part of the groups allowed to use federation.

Removing all groups from "Limit to groups" prevents the issue.

Actual behaviour

Conversation is not created or invite fails. nc2 logs:

Received a federation invite for user that is not allowed to use Talk Federation

[nickvergessen]

The label in the UI is wrong. The idea is to restrict who can use federation. So it is meant to control invites in and out.