nextcloud / spreed

🗨️ Nextcloud Talk – chat, video & audio calls for Nextcloud
https://nextcloud.com/talk
GNU Affero General Public License v3.0
1.63k stars 436 forks source link

Add the ability to disable specific or all chat embeds (Mainly for Nextcloud Office) #13685

Open ThibautPlg opened 1 day ago

ThibautPlg commented 1 day ago

How to use GitHub


Feature request

Which Nextcloud Version are you currently using: NC28 or newer

Is your feature request related to a problem? Please describe. We are using Nextcloud talk daily for our meetings and are often referencing Nextcloud Office documents. That can be a list of documents, notes for futures edits or simply a link for meeting participants to open and start editing. However, the automatic Collabora iframe is always instantiated in the chat, bringing some problems:

These problems are more important with the Collabora integration, but same can be said for other Nextcloud apps (even text!) that appears as iframes.

A quick performance review using Firefox's about:performance tab inspector.

Opening a Nextcloud Talk conversation without even being in a call already eats up 800Mb of ram. These numbers can and will vary depending on every browser, hardware, Nextcloud and whatever, but that gives a nice idea of the performance issue introduced solely by the iframes imo.

Describe the solution you'd like The ability to disable Collabora's iframes embeds. If not possible or too difficult, the ability to disable all embeds. Disabling Collabora embeds would have little to no impact for us as the iframe is too little to do any work anyway.

Describe alternatives you've considered Pasting Nextcloud files links to the chat with a typo or a space to prevent iframes instantiating


Best regards,

Antreesy commented 1 day ago

Hi, thanks for the report! We're waiting for this PR to be released: https://github.com/nextcloud-libraries/nextcloud-vue/pull/6151 Then we'll discuss, whether widgets in the chat should be the always disabled, or disabled by default and then configured by user

ThibautPlg commented 1 day ago

I checked for opened issues but not PRs even less in nextcloud-vue lib. Thanks :) Looking forward to this!