nextcloud / spreed

🗨️ Nextcloud Talk – chat, video & audio calls for Nextcloud
https://nextcloud.com/talk
GNU Affero General Public License v3.0
1.61k stars 428 forks source link

UX for adding participant from sidebar too direct #4484

Open PVince81 opened 3 years ago

PVince81 commented 3 years ago

Steps to reproduce

  1. Start a conversation with many people
  2. On the right sidebar in the participant list, type in some search term in the top field
  3. Scroll down then click an entry "by mistake" instead of another one (maybe wanting to click on the three dots for initiating a private chat)

Expected behaviour

Nothing should happen, I'd consider this a simple search result. If I want to add a participant, there should be a "+" button behind that I can click.

Actual behaviour

User or group gets added directly after clicking. The wrong user got added to the conversation, not sure if they are allowed to see it... need to kick that user out quickly.

Talk app

Talk app version: 11.0 pre-alpha (git)

@nextcloud/designers-talk

nickvergessen commented 3 years ago

Yeah a + button where the … button normally is sounds like a good idea.

jancborchardt commented 3 years ago

Since for creating conversations we have the "pick people" flow in the modal, would this also make sense here? It allows you to search, pick some people, remove ones you accidentally added, and then confirm. @ma12-co

marcoambrosini commented 3 years ago

Since for creating conversations we have the "pick people" flow in the modal, would this also make sense here?

I also thought about that @jancborchardt but i think that the selection bubbles between the two lists would not work.

I suggest we:

IMG_20201102_161240

marcoambrosini commented 3 years ago

Basically what I propose would look like this for small to medium groups

IMG_20201102_165353