Failed message doesn't render the @mention inline avatar

ChristophWurst commented 1 year ago

How to use GitHub

Please use the 👍 reaction to show that you are affected by the same issue.
Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
Subscribe to receive notifications on status change and new comments.

Steps to reproduce

Composer a chat message including a \@mention of another user
See the user avatar
Send the message
??? server error ???
See that the message wasn't sent with the option to resend

Expected behaviour

Message to resend renders the \@mention

Actual behaviour

I see \@joas in the chat window

Talk app

Talk app version: the lastest for 24 I guess

Custom Signaling server configured: yes/no and version (see additional admin settings: /index.php/index.php/settings/admin/talk#signaling_server)

Custom TURN server configured: yes/no (see additional admin settings: /index.php/settings/admin/talk#turn_server)

Custom STUN server configured: yes/no (see additional admin settings: /index.php/settings/admin/talk#stun_server)

Browser

Microphone available: yes/no

Camera available: yes/no

Operating system: Windows/Ubuntu/...

Browser name: Firefox/Chrome/...

Browser version: 85/96/...

Browser log

``` Insert your browser log here, this could for example include: a) The javascript console log b) The network log c) ... ```

Server configuration

Operating system: Ubuntu/RedHat/...

Web server: Apache/Nginx

Database: MySQL/Maria/SQLite/PostgreSQL

PHP version: 7.4/8.0/8.1

Nextcloud Version: (see admin page)

List of activated apps:

``` If you have access to your command line run e.g.: sudo -u www-data php occ app:list from within your server installation folder ```

Nextcloud configuration:

``` If you have access to your command line run e.g.: sudo -u www-data php occ config:list system from within your Nextcloud installation folder ```

Server log (data/nextcloud.log)

``` Insert your server log here ```

nickvergessen commented 1 year ago

Yeah, so the problem is the message never hit the server so we also don't know which parameters or magic words are recognized etc. If we would replace them and keep a record of the rich-object parameters, that would break resending the message if not re-replaced on re-sending.

Also we could only do it for mentions you autocompleted via tribute. if you manually typed @admin we never waited for a server response and there also don't have a mention chip or the data (display name, etc) available.

nickvergessen commented 7 months ago

Antreesy commented 5 months ago

the message never hit the server

As you said, we don't have messageParameters yet to show a message, although that could be mocked by client.

we could only do it for mentions you autocompleted via tribute

Only if we imitate somehow the click on a tribute to generate a mention chip. But that would require a server request for autocomplete options. Issue becomes more relevant now, as we added message editing

nextcloud / spreed