search

nextcloud / spreed

🗨️ Nextcloud Talk – chat, video & audio calls for Nextcloud
https://nextcloud.com/talk
GNU Affero General Public License v3.0
1.64k stars 437 forks source link

publicshare.css overrides break the top-left nextcloud logo #8561

Open jonas2515 opened 1 year ago

jonas2515 commented 1 year ago

Steps to reproduce

  1. Update Nextcloud to version 25.0.2
  2. Open public sharing page where publicshare.css is in effect
  3. Notice how the top-left logo of the Nextcloud instance is missing

Talk app

Talk app version: 15.0.2

It seems that something in Nextcloud CSS has changed and that broke the CSS overrides done in publicshare.css.

In particular, the issue seems to be that due to the <header> element being made position: static instead of position: absolute, that element is now no longer the reference element for any position: absolute elements inside it. The logo <div> depends on exactly that position: absolute to be positioned correctly though: With the position: static on the <header> the logo now uses the <body> as its reference element and ends up positioned wrongly.

A quick workaround for this appears to be using position: relative instead of position: static as the <header> style in publicshare.css. On a quick check it appears that the override still does what it's supposed to, but it would be best if someone with more knowledge could confirm or propose something better.

cc @danxuliu

danxuliu commented 1 year ago

Thanks for the detailed information!

Fortunately this is already fixed in the first release candidate of Nextcloud server 25.0.3 :-) (apparently due to the change of the logo from a div to an image).

danxuliu commented 1 year ago

Turns out that the fix will be reverted for Nextcloud 25.0.4, as it was found that it introduced some regressions. We will keep an eye on the follow-ups to that reversion just in case we end needing to change something in Talk too. Nevertheless, if this slips by and the issue happens again in Nextcloud 25.0.4 please reopen :-)

nickvergessen commented 1 year ago

Also the case in 26

nickvergessen commented 12 months ago

It's not the logo anymore but all the background is now missing:

Video verification Normal password
Bildschirmfoto vom 2023-11-21 09-55-56 Bildschirmfoto vom 2023-11-21 09-55-46