search

nextcloud / spreed

🗨️ Nextcloud Talk – chat, video & audio calls for Nextcloud
https://nextcloud.com/talk
GNU Affero General Public License v3.0
1.61k stars 430 forks source link

Join call / leave call sound is played for internal clients #8843

Open SystemKeeper opened 1 year ago

SystemKeeper commented 1 year ago
  1. Start a call in Chrome
  2. Start recording
  3. When the internal participant (= the recording client) joins, the joining sound is played

Expected: Internal clients are already hidden in the participant view and should therefore not generate a joining / leaving sound.

nickvergessen commented 1 year ago

Hmm :/

The internal client is also used for SIP users that dial in via phone. Are they distinguishable @danxuliu ?

SystemKeeper commented 1 year ago

Hmm… so SIP participants should actually be shown in the call view, right? Regarding https://github.com/nextcloud/talk-ios/pull/1094

danxuliu commented 1 year ago

If I am not mistaken one thing is the SIP bridge, which uses an internal client and is therefore hidden (also in the web UI since SIP was introduced), and another thing are the SIP participants, which use a virtual session and work like other participants, except in how their flags are updated.

nickvergessen commented 10 months ago

Expected: Internal clients are already hidden in the participant view and should therefore not generate a joining / leaving sound.

Still not sure about this. I think it's fine, but I would play another sound which clearly indicates the recording

SystemKeeper commented 10 months ago

but I would play another sound which clearly indicates the recording

I think that would be a good solution to this.