Decide how the viewer should interact with the sidebar

nextcloud / spreed

🗨️ Nextcloud Talk – chat, video & audio calls for Nextcloud

https://nextcloud.com/talk

GNU Affero General Public License v3.0

1.64k stars 437 forks source link

Decide how the viewer should interact with the sidebar #9427

Open marcoambrosini opened 1 year ago

marcoambrosini commented 1 year ago

jancborchardt commented 1 year ago

@marcoambrosini When the viewer is open, could the sidebar just act as if it's also fullscreen? That is, overlap the header, and no gap on right and bottom (and no rounded corners)?

jancborchardt commented 1 year ago

So basically it should look the same as if it's the Files sidebar in the viewer. Note right now the Viewer also overlaps the left part of the sidebar a bit.

skjnldsv commented 1 year ago

It's a bug in text. Viewer is handling the sidebar just fine https://github.com/nextcloud/viewer/issues/1633

marcoambrosini commented 1 year ago

Sorry I was still slowly writing the description @skjnldsv, it's not about the width

When the viewer is open, could the sidebar just act as if it's also fullscreen? That is, overlap the header, and no gap on right and bottom (and no rounded corners)?

What about the header though? We'd loose notifications and status setting.

skjnldsv commented 1 year ago

Ok, it seems the Talk sidebar is missing some stuff then We do the sidebar fullscreen on files, the specs have already been defined. :)

skjnldsv commented 1 year ago

https://github.com/nextcloud/server/blob/ea67129b64eaf56f185dda0a1b6a57887021f686/apps/files/src/views/Sidebar.vue#L242 https://github.com/nextcloud/server/blob/ea67129b64eaf56f185dda0a1b6a57887021f686/apps/files/src/views/Sidebar.vue#L481-L490 https://github.com/nextcloud/viewer/blob/c926f1836fd0609945dd2d233b060e874fd0d3f7/src/views/Viewer.vue#L467-L474

I think it would make sense to have this straight as a prop in nc-vue. It's also not really about a discussion on how it should look, as this has been addressed before. But how should the api look like for all Sidebar to be compatible with Viewer imho :)

marcoambrosini commented 1 year ago

That could be a very good first step to get rid of this awful looking bug in talk, but it has some drawbacks:

Jumping content in the sidebar
No user status change while the viewer is open
No notifications access while the viewer is open

Going forward, could we have both full and non fullscreen options for the viewer+sidebar combo and link them together?