Fix filters for meta columns

nextcloud / tables

🍱 Nextcloud tables app

https://apps.nextcloud.com/apps/tables

GNU Affero General Public License v3.0

148 stars 23 forks source link

Fix filters for meta columns #1002

Closed juliusknorr closed 6 months ago

juliusknorr commented 6 months ago

fix: Avoid failing if a view filter contains a meta column
chore: Move meta column identifiers to constants

Likely fixes #998

enjeck commented 6 months ago

Cool, this probably also fixes this https://github.com/nextcloud/tables/pull/979. We had been getting similar error messages for the vacation template, and I couldn't figure out how to properly fix it

juliusknorr commented 6 months ago

Cool, this probably also fixes this #979. We had been getting similar error messages for the vacation template, and I couldn't figure out how to properly fix it

Oh indeed, i also didn't have this on my radar when reviewing your PR. Now I gave this a try with reverting your fix, the vacation request template seems to work properly again with this PR.

juliusknorr commented 6 months ago

Pushed the revert and two more commits to fix an inconsistency compared to previous versions. Also moved frontend code to use the same constants

blizzz commented 6 months ago

Cool, this probably also fixes this #979. We had been getting similar error messages for the vacation template, and I couldn't figure out how to properly fix it

And i had a foul feeling not seeing constants there.

juliusknorr commented 6 months ago

/backport to stable0.7