enh: Consolidate user/group search code

enjeck commented 5 months ago

Fixes #1003

enjeck commented 4 months ago

TODO

[x] Do Applications Cypress test first so we can use it to ensure this doesn't break Applications shares: https://github.com/nextcloud/tables/issues/994
[x] Decide whether to rename NcUserAndGroupPicker.vue for transfers only
[x] Refactor ShareForm.vue

github-actions[bot] commented 4 months ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

enjeck commented 3 months ago

I noticed that when I initially create a context, I can add users to the user select in the "Share with accounts" / "Share with users" field, but after it is created I cannot add any more users. I can remove users, just not use the select anymore. Same goes for when I try to transfer the context to someone else, I can't use the drop-down select.

I don't get any browser console errors, so if you can't reproduce, may just be a browser thing on my end.

Thanks for testing. I can't reproduce the problem, it works fine for me :thinking:

nextcloud / tables

enh: Consolidate user/group search code #1025