nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
143 stars 24 forks source link

Link type column data reset after row update #1036

Open Jednadvacet opened 5 months ago

Jednadvacet commented 5 months ago

Steps to reproduce

  1. Fill data column of existing row. The column type should be link. My row has three link fields.
  2. Save row.
  3. Row saved. Link fields are cleared.

Expected behavior

Row update saves all fields.

Actual behavior

Link fields are cleared.

Tables app version

0.7.1.

Browser

Edge

Client operating system

No response

Operating system

Ubuntu 20.04

Web server

Nginx

PHP engine version

PHP 8.1

Database

PostgreSQL

Additional info

No response

Jednadvacet commented 4 months ago

Seems that the issue is connected with charset. Typical Czech language characters ščřžýáíěé in a link title call this errror:

Value {"title":"Ing. Tom\u00e1\u0161 \u0160enky\u0159\u00edk","value":"https:\/\/cloud.lbtechnet.cz\/apps\/contacts\/direct\/contact\/b08ce89e-2f35-48e5-b499-484a23185658~contacts","providerId":"url"} cannot be parsed as the column 52 does not allow the provider: url

New row is saved properly, update resets.

0.7.2. too.

Jednadvacet commented 4 months ago

Quick fix: Link type fields should have at least 2 subtypes (eg. Files + Url). Saving rows doesn't clear other link fields anymore.

juliushaertl commented 4 months ago

Thanks, we should of course fix that to not empty the value and provide a proper hint on why that fails.

juliushaertl commented 4 months ago

Might be worth to reconsider if the subtypes should actually limit what you can insert into an URL field or if those should just be used for search suggestions.

lars-becker commented 3 months ago

Quick fix: Link type fields should have at least 2 subtypes (eg. Files + Url). Saving rows doesn't clear other link fields anymore.

Thanks that solved the problem with repeated data loss for us. This problem should be fixed ASAP.