search

nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
133 stars 21 forks source link

feat: submit row details with ctrl + enter #1112

Closed luka-nextcloud closed 3 weeks ago

luka-nextcloud commented 1 month ago
elzody commented 1 month ago

Seems like both additions are the same code. Not sure if it would be an overkill or not, but maybe I would be in favor of moving this to something like a mixin so that both components can share it? It would cut down on the redundancy a little bit, but it's also a small addition and it could pollute the mixins with something so small in comparison. Not sure, what are you thoughts on it? Otherwise it looks good to me though.

luka-nextcloud commented 3 weeks ago

@elzody I think they are too small to move to a mixin. We can consider about it later when those functions expand more.